Merge lp://staging/~simpoir/landscape-client-charm/sync-charmhelpers-and-keys into lp://staging/landscape-client-charm

Proposed by Simon Poirier
Status: Merged
Approved by: Simon Poirier
Approved revision: 69
Merged at revision: 69
Proposed branch: lp://staging/~simpoir/landscape-client-charm/sync-charmhelpers-and-keys
Merge into: lp://staging/landscape-client-charm
Diff against target: 2622 lines (+1686/-161)
24 files modified
Makefile (+1/-2)
hooks/charmhelpers/__init__.py (+65/-4)
hooks/charmhelpers/core/hookenv.py (+450/-28)
hooks/charmhelpers/core/host.py (+170/-11)
hooks/charmhelpers/core/host_factory/centos.py (+16/-0)
hooks/charmhelpers/core/host_factory/ubuntu.py (+58/-0)
hooks/charmhelpers/core/kernel.py (+2/-2)
hooks/charmhelpers/core/services/base.py (+18/-7)
hooks/charmhelpers/core/strutils.py (+64/-5)
hooks/charmhelpers/core/sysctl.py (+21/-10)
hooks/charmhelpers/core/templating.py (+18/-9)
hooks/charmhelpers/core/unitdata.py (+8/-1)
hooks/charmhelpers/fetch/__init__.py (+19/-9)
hooks/charmhelpers/fetch/archiveurl.py (+1/-1)
hooks/charmhelpers/fetch/bzrurl.py (+2/-2)
hooks/charmhelpers/fetch/centos.py (+1/-1)
hooks/charmhelpers/fetch/giturl.py (+2/-2)
hooks/charmhelpers/fetch/python/__init__.py (+13/-0)
hooks/charmhelpers/fetch/python/debug.py (+54/-0)
hooks/charmhelpers/fetch/python/packages.py (+154/-0)
hooks/charmhelpers/fetch/python/rpdb.py (+56/-0)
hooks/charmhelpers/fetch/python/version.py (+32/-0)
hooks/charmhelpers/fetch/snap.py (+33/-5)
hooks/charmhelpers/fetch/ubuntu.py (+428/-62)
To merge this branch: bzr merge lp://staging/~simpoir/landscape-client-charm/sync-charmhelpers-and-keys
Reviewer Review Type Date Requested Status
Daniel Manrique (community) Approve
🤖 Landscape Builder test results Approve
Review via email: mp+367923@code.staging.launchpad.net

Commit message

Sync charmhelpers to avoid key errors on refresh.

Description of the change

Sync charmhelpers. This pulls an upstream change which import keys before updating repos, thus avoid errors.

Testing instructions:

juju deploy ubuntu
juju deploy . --config install_sources='["deb http://ppa.launchpad.net/landscape/18.03/ubuntu bionic main"]' --config install_keys='["-----BEGIN PGP PUBLIC KEY BLOCK-----\\nVersion: SKS 1.1.6\\nComment: Hostname: keyserver.ubuntu.com\\n\\nmI0ESXN/egEEAOgRYISU9dnQm4BB5ZEEwKT+NKUDNd/DhMYdtBMw9Yk7S5cyoqpbtwoPJVzK\\nAXxq+ng5e3yYypSv98pLMr5UF09FGaeyGlD4s1uaVFWkFCO4jsTg7pWIY6qzO/jMxB5+Yu/G\\n0GjWQMNKxFk0oHMa0PhNBZtdPacVz65mOVmCsh/lABEBAAG0G0xhdW5jaHBhZCBQUEEgZm9y\\nIExhbmRzY2FwZYi2BBMBAgAgBQJJc396AhsDBgsJCAcDAgQVAggDBBYCAwECHgECF4AACgkQ\\nboWobkZStOb+rwP+ONKUWeX+MTIPqGWkknBPV7jm8nyyIUojC4IhS+9YR6GYnn0hMABSkEHm\\nIV73feKmrT2GESYI1UdYeKiOkWsPN/JyBk+eTvKet0qsw5TluqiHSW+LEi/+zUyrS3dDMX3o\\nyaLgYa+UkjIyxnaKLkQuCiS+D+fYwnJulIkhaKObtdE=\\n=UwRd\\n-----END PGP PUBLIC KEY BLOCK-----"]'
juju relate landscape-client ubuntu

juju debug-log --replay | grep NO_PUBKEY
# no output after deployment means success.

To post a comment you must log in.
Revision history for this message
🤖 Landscape Builder (landscape-builder) :
review: Abstain (executing tests)
Revision history for this message
🤖 Landscape Builder (landscape-builder) wrote :
review: Approve (test results)
Revision history for this message
🤖 Landscape Builder (landscape-builder) :
review: Abstain (executing tests)
Revision history for this message
🤖 Landscape Builder (landscape-builder) wrote :
review: Needs Fixing (test results)
Revision history for this message
🤖 Landscape Builder (landscape-builder) :
review: Abstain (executing tests)
Revision history for this message
🤖 Landscape Builder (landscape-builder) wrote :
review: Approve (test results)
Revision history for this message
🤖 Landscape Builder (landscape-builder) :
review: Abstain (executing tests)
Revision history for this message
🤖 Landscape Builder (landscape-builder) wrote :
review: Approve (test results)
Revision history for this message
Daniel Manrique (roadmr) wrote :

+1, I'm not reviewing charmhelpers code but the sync seems OK to me and all the automated tests passed.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: