Ubuntu system image

Merge lp://staging/~sil2100/ubuntu-system-image/server-copy-image-phased into lp://staging/ubuntu-system-image/server

  1. server-copy-image-phased
  2. Merge into server
Proposed by Łukasz Zemczak
Status: Merged
Merge reported by: Steve Langasek
Merged at revision: not available
Proposed branch: lp://staging/~sil2100/ubuntu-system-image/server-copy-image-phased
Merge into: lp://staging/ubuntu-system-image/server
Diff against target: 26 lines (+9/-0)
1 file modified
bin/copy-image (+9/-0)
To merge this branch: bzr merge lp://staging/~sil2100/ubuntu-system-image/server-copy-image-phased
Reviewer Review Type Date Requested Status
Steve Langasek (community) Approve
Review via email: mp+256339@code.staging.launchpad.net

Commit message

Add the additional optional argument of --phased-percentage that can be set when executing copy-image. The default phased percentage is 100%, but the argument can be used to set a new initial value.

Description of the change

Add the additional optional argument of --phased-percentage that can be set when executing copy-image. The default phased percentage is 100%, but the argument can be used to set a new initial value.

To post a comment you must log in.
Revision history for this message
Łukasz Zemczak (sil2100) wrote :

Tested on a local system-image server. I checked both the case of setting a custom phased percentage value and leaving the default value (which currently is 100%). We can do it that way as set_phased_percentage doesn't write down the value if it's 100 (since then there's simply no entry for phased percentage)

Revision history for this message
Steve Langasek (vorlon) wrote :

This looks good to me. I thought about whether the percentage should be an optional argument to create_image() itself, but looking at it I don't see think that's advantageous because it implies that you could have two different update paths (full update vs. delta) that have different phased percentages andwe specifically don't want to allow that. So keeping the existing set_phased_percentage() api avoids any accidents there.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches