Bileto

Merge lp://staging/~sil2100/bileto/dashboard_add_qa_colors into lp://staging/bileto

  1. dashboard_add_qa_colors
  2. Merge into trunk
Proposed by Łukasz Zemczak
Status: Rejected
Rejected by: Robert Bruce Park
Proposed branch: lp://staging/~sil2100/bileto/dashboard_add_qa_colors
Merge into: lp://staging/bileto
Diff against target: 50 lines (+15/-5)
2 files modified
tickets/static/dashboard.html (+1/-1)
tickets/static/dashboard.js (+14/-4)
To merge this branch: bzr merge lp://staging/~sil2100/bileto/dashboard_add_qa_colors
Reviewer Review Type Date Requested Status
CU2D maintainers Pending
Review via email: mp+266603@code.staging.launchpad.net

Commit message

Make sure that the dashboard silo status color also changes basing on QA status, informing the trainguards of when a silo is rejected or signed-off.

Description of the change

Make sure that the dashboard silo status color also changes basing on QA status, informing the trainguards of when a silo is rejected or signed-off.

To post a comment you must log in.
Revision history for this message
Łukasz Zemczak (sil2100) wrote :

Still need to actually test it somewhere.

Revision history for this message
Robert Bruce Park (robru) wrote :

Oh haha, I didn't even see this. I fixed this already in a recent commit I did.

Also, "somewhere" is the staging area, branches can be configured the same way as for jenkins, as per the instructions:

https://wiki.canonical.com/UbuntuEngineering/CI/Playbook/StagingTrain

Unmerged revisions

201. By Łukasz Zemczak

Add QA status to have effect on silo colors in the dashboard.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches