Merge lp://staging/~sergiusens/ubuntu/wily/ubuntu-core-config/azure-datasource into lp://staging/ubuntu/wily/ubuntu-core-config

Proposed by Sergio Schvezov
Status: Merged
Merged at revision: 30
Proposed branch: lp://staging/~sergiusens/ubuntu/wily/ubuntu-core-config/azure-datasource
Merge into: lp://staging/ubuntu/wily/ubuntu-core-config
Prerequisite: lp://staging/~sergiusens/ubuntu/wily/ubuntu-core-config/frameworks-writable
Diff against target: 21 lines (+9/-0)
2 files modified
debian/changelog (+6/-0)
etc/cloud/cloud.cfg.d/99-snappy-azure.cfg (+3/-0)
To merge this branch: bzr merge lp://staging/~sergiusens/ubuntu/wily/ubuntu-core-config/azure-datasource
Reviewer Review Type Date Requested Status
Ricardo Salveti (community) Needs Fixing
Ben Howard (community) Approve
Michael Vogt (community) Needs Information
Review via email: mp+260201@code.staging.launchpad.net
To post a comment you must log in.
Revision history for this message
Michael Vogt (mvo) wrote :

Thanks, this looks good. I added Ben to ensure nothing breaks if this gets merged on azure. Is there anything else that needs changing when this lands (does it obsoletes the azure device tarball for example?).

review: Needs Information
Revision history for this message
Sergio Schvezov (sergiusens) wrote :

On Wed, May 27, 2015 at 07:41:47AM -0000, Michael Vogt wrote:
> Review: Needs Information
>
> Thanks, this looks good. I added Ben to ensure nothing breaks if this gets merged on azure. Is there anything else that needs changing when this lands (does it obsoletes the azure device tarball for example?).

Yes it obsoletes the device tarball for azure, but that is a different
step ;-)

It also allows to remove python 2 from the seeds, but we can wait for
him to answer.

Revision history for this message
Ben Howard (darkmuggle-deactivatedaccount) wrote :

+1.

The only part that keeps this from obsoleting the Azure device tarball is the lack of "rootdelay=300." But it does remove the need for WALinuxAgent as well as Python 2.

Looks good to me.

review: Approve
Revision history for this message
Ricardo Salveti (rsalveti) wrote :

Needs merge with trunk and changelog update.

review: Needs Fixing
23. By Sergio Schvezov

Merging trunk

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches