Merge lp://staging/~sergiusens/snapcraft/1510160 into lp://staging/~snappy-dev/snapcraft/core

Proposed by Sergio Schvezov
Status: Merged
Approved by: Sergio Schvezov
Approved revision: 252
Merged at revision: 253
Proposed branch: lp://staging/~sergiusens/snapcraft/1510160
Merge into: lp://staging/~snappy-dev/snapcraft/core
Diff against target: 90 lines (+44/-0)
4 files modified
integration-tests/units/jobs.pxu (+6/-0)
snapcraft/cmds.py (+10/-0)
snapcraft/main.py (+6/-0)
snapcraft/tests/test_cmds.py (+22/-0)
To merge this branch: bzr merge lp://staging/~sergiusens/snapcraft/1510160
Reviewer Review Type Date Requested Status
Leo Arias (community) Approve
John Lenton (community) Approve
Review via email: mp+275736@code.staging.launchpad.net

Commit message

Add list-plugins

To post a comment you must log in.
Revision history for this message
John Lenton (chipaca) wrote :

LGTM! :)

review: Approve
Revision history for this message
Leo Arias (elopio) wrote :

The only problem I see is that when you add a new plugin, you will have to change two tests. +1 anyway as that might be a good thing.

I also have a question, what happens if somebody wants to name the plugin my_plugin, with underscore instead of a dash?

review: Approve
Revision history for this message
Sergio Schvezov (sergiusens) wrote :

> The only problem I see is that when you add a new plugin, you will have to
> change two tests. +1 anyway as that might be a good thing.

This would also break if there is another package that puts stuff here, very dodgy, but possible. I prefer the tight control in some aspects. In the end, 'list-plugins' could also just be a fixed list :-P

> I also have a question, what happens if somebody wants to name the plugin
> my_plugin, with underscore instead of a dash?

It is my question too, we would just need some tight control here. This is the inherited design. We can eventually grab the name from an attribute inside the module.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches