Merge lp://staging/~sergiusens/phablet-extras/qtbase-opensource-src-gles into lp://staging/~phablet-team/phablet-extras/qtbase-opensource-src-gles

Proposed by Sergio Schvezov
Status: Needs review
Proposed branch: lp://staging/~sergiusens/phablet-extras/qtbase-opensource-src-gles
Merge into: lp://staging/~phablet-team/phablet-extras/qtbase-opensource-src-gles
Diff against target: 594 lines (+165/-75)
9 files modified
debian/changelog (+6/-0)
debian/control (+137/-62)
debian/libqt5core5a-gles.shlibs (+1/-0)
debian/libqt5dbus5-gles.shlibs (+1/-0)
debian/libqt5gui5-gles.shlibs (+1/-0)
debian/libqt5opengl5-gles.shlibs (+1/-0)
debian/libqt5widgets5-gles.shlibs (+1/-0)
debian/mark_private_symbols.sh (+1/-1)
debian/rules (+16/-12)
To merge this branch: bzr merge lp://staging/~sergiusens/phablet-extras/qtbase-opensource-src-gles
Reviewer Review Type Date Requested Status
Ubuntu Phablet Team Pending
Review via email: mp+211808@code.staging.launchpad.net
To post a comment you must log in.
163. By Sergio Schvezov

Repackging for building gles variants for all arches.

164. By Sergio Schvezov

Fix replaces/breaks and depends as much as possible on original package

Revision history for this message
Timo Jyrinki (timo-jyrinki) wrote :

Reading the diff it seems consistent and could work, thanks to the various Provides: and .shlibs used. I don't know what else is needed when this is available or if this would be enough for the emulator purposes, but yes this kind of package could coexist with the qtbase-opensource-src similar to the touch variant of the qtmultimedia.

I'm unsure of the need to restrict the Breaks/Replaces to "<= 5.2.1+dfsg+"? I mean, if we'd ship say qtdeclarative 5.2.1+git20140326 or simply 5.3 later on, this packaging would break. But maybe I'm not seeing something why this couldn't simply be Breaks/Replaces without version number.

For an upstream update, https://bugreports.qt-project.org/browse/QTBUG-36829 was updated to say that the full runtime configurability is planned eventually but there is no timeline yet - so no knowledge of whether it'll be in eg. 5.4 or 5.5.

Revision history for this message
Sergio Schvezov (sergiusens) wrote :

On Wed, Mar 26, 2014 at 10:43 AM, Timo Jyrinki
<email address hidden> wrote:
> Reading the diff it seems consistent and could work, thanks to the various Provides: and .shlibs used. I don't know what else is needed when this is available or if this would be enough for the emulator purposes, but yes this kind of package could coexist with the qtbase-opensource-src similar to the touch variant of the qtmultimedia.

I have this built in my PPA ppa:sergiusens/qt-gles

We need to to one thing more as well; the original package would need
to have a similar shlibs/substvar logic so the stuff that builds
against these libs don't need to rebuild (given no abi/symbols
breakage)

> I'm unsure of the need to restrict the Breaks/Replaces to "<= 5.2.1+dfsg+"? I mean, if we'd ship say qtdeclarative 5.2.1+git20140326 or simply 5.3 later on, this packaging would break. But maybe I'm not seeing something why this couldn't simply be Breaks/Replaces without version number.

The problem is breaking ABI/API if 5.3 changes, so this forces us to
relook into it and avoid the qtmultimedia problem.

> For an upstream update, https://bugreports.qt-project.org/browse/QTBUG-36829 was updated to say that the full runtime configurability is planned eventually but there is no timeline yet - so no knowledge of whether it'll be in eg. 5.4 or 5.5.
> --
> https://code.launchpad.net/~sergiusens/phablet-extras/qtbase-opensource-src-gles/+merge/211808
> You are the owner of lp:~sergiusens/phablet-extras/qtbase-opensource-src-gles.

Unmerged revisions

164. By Sergio Schvezov

Fix replaces/breaks and depends as much as possible on original package

163. By Sergio Schvezov

Repackging for building gles variants for all arches.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches