nuntium

Merge lp://staging/~sergiusens/nuntium/roll_over_context into lp://staging/nuntium

  1. roll_over_context
  2. Merge into trunk
Proposed by Sergio Schvezov
Status: Merged
Approved by: Ricardo Salveti
Approved revision: 72
Merged at revision: 72
Proposed branch: lp://staging/~sergiusens/nuntium/roll_over_context
Merge into: lp://staging/nuntium
Diff against target: 351 lines (+202/-53)
2 files modified
ofono/context_test.go (+166/-31)
ofono/modem.go (+36/-22)
To merge this branch: bzr merge lp://staging/~sergiusens/nuntium/roll_over_context
Reviewer Review Type Date Requested Status
Ricardo Salveti (community) Approve
PS Jenkins bot continuous-integration Approve
Review via email: mp+235071@code.staging.launchpad.net

Commit message

Iterate over a list of possible valid MMS contexts and store the preferred one

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:72
http://jenkins.qa.ubuntu.com/job/nuntium-ci/9/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/nuntium-utopic-amd64-ci/9
    SUCCESS: http://jenkins.qa.ubuntu.com/job/nuntium-utopic-armhf-ci/9
        deb: http://jenkins.qa.ubuntu.com/job/nuntium-utopic-armhf-ci/9/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/nuntium-utopic-i386-ci/9

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/nuntium-ci/9/rebuild

review: Approve (continuous-integration)
Revision history for this message
Ricardo Salveti (rsalveti) wrote :

LGTM, but have no way to test that. As you added unit tests for the new behaviour, we should be covered.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches