lp://staging/~sergiusens/gocheck/expected_panic_regex_in_tests
- Get this branch:
- bzr branch lp://staging/~sergiusens/gocheck/expected_panic_regex_in_tests
Branch merges
- Gustavo Niemeyer: Pending requested
-
Diff: 54 lines (+13/-3)1 file modifiedfixture_test.go (+13/-3)
Branch information
Recent revisions
- 83. By Dave Cheney
-
gocheck: serialize log writes
Fixes LP #1084878.
The race detector cannot profile gocheck tested code due to this race.
R=rog, niemeyer, fwereade
CC=
https://codereview. appspot. com/6862050 - 82. By Gustavo Niemeyer
-
Add -gocheck.list flag.
This is an integration of Roger's change:
https:/
/codereview. appspot. com/5705044/ I've just fixed the conflicts of merging with tip.
- 81. By John A Meinel
-
This fixes a bunch of failing tests on Windows.
Specifically, a lot of tests were asserting something like:
FAIL: filename.go ...
While on Windows, the full paths are given:
FAIL: C:/dev/
go/gocheck/ filename. go I dug into it, and it turns out that nicePath was comparing
function.FileLine() to os.Getwd(). However, function.FileLine() returns
'C:/path/to/foo' while 'os.Getwd()' returns 'C:\path\to\foo'.I also did one more quick change, which was to always append the trailing '/'.
That way we don't have to do that on every call to nicePath() (and I checked
that only nicePath uses initWD).At the moment, there are only 2 remaining tests failing. Both because the
failure messages don't include the module name. This is with golang r58. So it
is possible that golang changed something (so it needs to be fixed anyway), or
it is possible it just works differently on Windows :(. - 77. By Gustavo Niemeyer
-
- Polished integration of benchmark code.
- Integrated showing of timing for succeeding tests.
- Fixed all tests accordingly.
Branch metadata
- Branch format:
- Branch format 7
- Repository format:
- Bazaar repository format 2a (needs bzr 1.16 or later)
- Stacked on:
- lp://staging/gocheck