gallery-app

Merge lp://staging/~sergiusens/gallery-app/click-support into lp://staging/gallery-app

click-support
Merge into trunk

Proposed by Sergio Schvezov on 2014-02-20

Status:	Merged
Merged at revision:	919
Proposed branch:	lp://staging/~sergiusens/gallery-app/click-support
Merge into:	lp://staging/gallery-app
Diff against target:	410 lines (+122/-57) 13 files modified CMakeLists.txt (+7/-5) click-build.sh (+16/-0) click/CMakeLists.txt (+1/-1) click/gallery-apparmor.json (+1/-0) click/gallery-content.json (+5/-0) click/manifest.json.in (+4/-3) desktop/CMakeLists.txt (+13/-6) desktop/gallery-app.desktop.in (+5/-6) rc/qml/AlbumsOverview.qml (+1/-1) rc/qml/Utility/PhotosToolbarActions.qml (+1/-1) tests/autopilot/gallery_app/tests/__init__.py (+59/-31) tests/autopilot/gallery_app/tests/test_album_view.py (+8/-3) tests/autopilot/gallery_app/tests/test_picker_mode.py (+1/-0)
To merge this branch:	bzr merge lp://staging/~sergiusens/gallery-app/click-support
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
PS Jenkins bot	continuous-integration	2014-02-20	Approve on 2014-02-21
Ken VanDine		2014-02-20	Pending
Bill Filler		2014-02-20	Pending
Review via email: mp+207515@code.staging.launchpad.net

This proposal supersedes a proposal from 2014-01-10.

Commit message

Click support

Description of the change

launch camera with appropriate click url in Qt.openrUrlExternally. depends on camera being released as a click

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-01-10: Posted in a previous version of this proposal

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/gallery-app-ci/628/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-01-11: Posted in a previous version of this proposal

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/gallery-app-ci/630/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-01-12: Posted in a previous version of this proposal

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/gallery-app-ci/631/rebuild

review: Approve (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-01-13: Posted in a previous version of this proposal

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/gallery-app-ci/632/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Bill Filler (bfiller) wrote on 2014-01-13: Posted in a previous version of this proposal

dropping the --fullscreen arg from the exec causes the app to not launched fullscreen on the devices anymore. it needs to be fullscreen so the top panel is hidden when a photo is viewed but no current way to do that dynamically - has to be all or nothing..

so, what we really want is to have the app determine which device it's running on and do fullscreen mode internally. it's correct to remove it from the desktop file/exec but we need to add the support in the code to run it fullscreen if !DESKTOP_MODE

review: Needs Fixing

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-01-13: Posted in a previous version of this proposal

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/gallery-app-ci/633/rebuild

review: Approve (continuous-integration)

Revision history for this message

Ken VanDine (ken-vandine) wrote on 2014-01-29: Posted in a previous version of this proposal

Needs click hook for content-hub, I proposed a branch to fix this.

https://code.launchpad.net/~ken-vandine/gallery-app/click_content_hub_source/+merge/203764

review: Needs Fixing

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-01-29: Posted in a previous version of this proposal

FAILED: Continuous integration, rev:909
http://jenkins.qa.ubuntu.com/job/gallery-app-ci/638/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/gallery-app-trusty-amd64-ci/63/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/gallery-app-trusty-armhf-ci/63/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/gallery-app-trusty-i386-ci/63/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/2724/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty-touch/2490/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/2726/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/2491/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/gallery-app-ci/638/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Ken VanDine (ken-vandine) on 2014-01-30: Posted in a previous version of this proposal

review: Approve

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-02-11: Posted in a previous version of this proposal

FAILED: Continuous integration, rev:910
http://jenkins.qa.ubuntu.com/job/gallery-app-ci/655/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/gallery-app-trusty-amd64-ci/80/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/gallery-app-trusty-armhf-ci/81/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/gallery-app-trusty-i386-ci/80/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/3139/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty-touch/2826/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/3141/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/2828/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/gallery-app-ci/655/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-02-12: Posted in a previous version of this proposal

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/gallery-app-ci/656/rebuild

review: Approve (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-02-12: Posted in a previous version of this proposal

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/gallery-app-ci/657/rebuild

review: Approve (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-02-13: Posted in a previous version of this proposal

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/gallery-app-ci/660/rebuild

review: Approve (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-02-13: Posted in a previous version of this proposal

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/gallery-app-ci/661/rebuild

review: Approve (continuous-integration)

Revision history for this message

Bill Filler (bfiller) wrote on 2014-02-14: Posted in a previous version of this proposal

Are there any related MPs required for this MP to build/function as expected?
Yes, lots. See the request in CI Train

Is your branch in sync with latest trunk (e.g. bzr pull lp:trunk -> no changes):
Yes

Did you perform an exploratory manual test run of your code change and any related functionality on device or emulator?
Yes

Did you successfully run all tests found in your component's Test Plan (https://wiki.ubuntu.com/Process/Merges/TestPlan/<package-name>) on device or emulator?
YES

If you changed the UI, was the change specified/approved by design?
N/A

If you changed the packaging (debian), did you subscribe a core-dev to this MP?
N/A

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-02-20: