Code review comment for ~sergiodj/ubuntu/+source/sssd:merge-2.7.1-2-kinetic

Revision history for this message
Andreas Hasenack (ahasenack) wrote :

I think you can merge these two commits. Usually in logical, but if you want to do it now on top of debian/sid that's also fine:

commit d36036c652ab62d942eb2a8f8fa800fea6a78e3e
Author: Sergio Durigan Junior <email address hidden>
Date: Mon Feb 14 16:16:18 2022 -0500

        - Remember how architecture lists in debian/control work.

commit 0d33597c0bec4a96959d9a770b7d2681707ab8e9
Author: Sergio Durigan Junior <email address hidden>
Date: Mon Feb 14 16:15:29 2022 -0500

        - d/control: Don't build sssd-tools on i386, now uninstallable due
          to added python3-{click,systemd} dependencies.

DEP8 tests look good as well. I'm unsure what vorlon expects to see after the upload, since i386 won't build, and thus won't migrate.

+1

review: Approve

« Back to merge proposal