Code review comment for ~sergiodj/ubuntu/+source/squid:merge-5.7-1-lunar

99-ubuntu-ssl-cert-snakeoil.patch ought to have DEP3 metadata by now. It's been around forever and looks like it'll stay with us permanently so would be worth formalizing it.

I'd also suggest along with that, to revise that change's changelog entry to match your standard style, i.e.:

     - d/p/99-ubuntu-ssl-cert-snakeoil.patch: Use snakeoil certificates
        via ssl-cert, and add a note about ssl to the default config file.

The GCC 11 FTBFS changelog entry could be similarly revised to match style of other entries.

https://github.com/squid-cache/squid/pull/887 looks like it was more or less agreed to and approved but still seems to be in process for over a year; might be worth a ping?

https://github.com/squid-cache/squid/pull/1118 looks like you've had an amicable interaction with upstream, but they're pushing back requesting more extensive refactoring work. I imagine it's not something you want to take time to tackle right now with the merge, but if you don't have anything too urgent on your plate this might be a good time in the cycle. Those kinds of data type refactorings tend not to be too hard but can require a few review roundtrips, so I'd not hold this merge for that work.

The changelog's version number needs fixed - it's 5.7-1ubuntu1~ppa1 but should be just 5.7-1ubuntu1.