Ubuntu
squid package

Merge ~sergiodj/ubuntu/+source/squid:openssl3-test2 into ubuntu/+source/squid:ubuntu/devel

  1. Git
  2. lp:~sergiodj/ubuntu/+source/squid
  3. openssl3-test2
  4. Merge into ubuntu/devel
Proposed by Sergio Durigan Junior
Status: Merged
Merged at revision: 819f9438ef366292a90afe3f0c3b562fb010ac95
Proposed branch: ~sergiodj/ubuntu/+source/squid:openssl3-test2
Merge into: ubuntu/+source/squid:ubuntu/devel
Diff against target: 911 lines (+823/-0)
14 files modified
debian/changelog (+19/-0)
debian/patches/openssl3-Declaration-of-CRYPTO_EX_dup-changed-again-in-3.0.patch (+30/-0)
debian/patches/openssl3-Detect-and-default-enable-OpenSSL-3.patch (+33/-0)
debian/patches/openssl3-Fix-EVP_PKEY_get0_RSA-is-deprecated.patch (+30/-0)
debian/patches/openssl3-Initial-DH-conversion-to-EVP_PKEY.patch (+140/-0)
debian/patches/openssl3-Refactor-Ssl-createSslPrivateKey.patch (+108/-0)
debian/patches/openssl3-Remove-stale-TODO-and-comment.patch (+27/-0)
debian/patches/openssl3-SSL_OP_-macro-definitions-changed-in-3.0.patch (+181/-0)
debian/patches/openssl3-Switch-to-BN_rand.patch (+69/-0)
debian/patches/openssl3-TODO-Upgrade-API-calls-verifying-loaded-DH-params-fi.patch (+36/-0)
debian/patches/openssl3-Tweak-RSA-key-generator.patch (+37/-0)
debian/patches/openssl3-Update-ECDH-key-settings.patch (+73/-0)
debian/patches/openssl3-Update-license-disclaimer.patch (+28/-0)
debian/patches/series (+12/-0)
Reviewer Review Type Date Requested Status
Andreas Hasenack (community) Approve
Canonical Server Pending
Review via email: mp+415283@code.staging.launchpad.net

Description of the change

This MP fixes the current FTBFS affecting squid when it builds against OpenSSL 3.0.

As I've been mentioning during our standup calls, upstream has been reviewing its PR for quite a while now. You can find the PR here:

https://github.com/squid-cache/squid/pull/694

This is where I got all the patches from. Although the PR is still being reviewed, and despite some unaddressed comments in it, I feel reasonably confident that we can go ahead and backport everything right now. I am subscribed to the PR and will monitor future changes to it (or to any other PRs that might be created as a result of this one), and if needed I intend to backport whathever new changes are proposed.

I built the package locally and ran its autopkgtests, both successfully:

autopkgtest [18:28:58]: @@@@@@@@@@@@@@@@@@@@ summary
upstream-test-suite PASS
squid PASS

I'm also building the package in a bileto PPA here:

https://launchpad.net/~ci-train-ppa-service/+archive/ubuntu/4778/+packages

Once everything is built, I will trigger autopkgtest runs for all supported architectures just to be sure. But again, I'm not expecting major problems with this change.

To post a comment you must log in.
Revision history for this message
Andreas Hasenack (ahasenack) wrote :

I'll look at this one

Revision history for this message
Andreas Hasenack (ahasenack) wrote :

+1

Patches match the PR commits.

I did a quick reverse-ssl-proxy test, to be sure it at least can load a certificate and handle a simple SSL connection, and it worked just fine.

Best indeed to keep an eye on that PR and adjust the patches if they change.

Thanks!

review: Approve
Revision history for this message
Sergio Durigan Junior (sergiodj) wrote :

On Thursday, February 10 2022, Andreas Hasenack wrote:

> +1
>
> Patches match the PR commits.
>
> I did a quick reverse-ssl-proxy test, to be sure it at least can load a certificate and handle a simple SSL connection, and it worked just fine.
>
> Best indeed to keep an eye on that PR and adjust the patches if they change.

Thanks for the review, Andreas.

Uploaded:

$ dput squid_5.2-1ubuntu3_source.changes
Trying to upload package to ubuntu
Checking signature on .changes
gpg: /home/sergio/work/squid/squid_5.2-1ubuntu3_source.changes: Valid signature from 106DA1C8C3CBBF14
Checking signature on .dsc
gpg: /home/sergio/work/squid/squid_5.2-1ubuntu3.dsc: Valid signature from 106DA1C8C3CBBF14
Uploading to ubuntu (via ftp to upload.ubuntu.com):
  Uploading squid_5.2-1ubuntu3.dsc: done.
  Uploading squid_5.2-1ubuntu3.debian.tar.xz: done.
  Uploading squid_5.2-1ubuntu3_source.buildinfo: done.
  Uploading squid_5.2-1ubuntu3_source.changes: done.
Successfully uploaded packages.

--
Sergio
GPG key ID: E92F D0B3 6B14 F1F4 D8E0 EB2F 106D A1C8 C3CB BF14

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches