Merge ~sergiodj/ubuntu/+source/net-snmp:merge-5.9.1-jammy into ubuntu/+source/net-snmp:debian/sid

Looks good, +1

Actually, one thing to check. This change introduced in the new debian version:

@@ -121,6 +122,7 @@ Depends: libc6-dev, libsnmp40 (=${binary:Version}), libnetsnmptrapd40 (=${binary
          libwrap0-dev, libssl-dev, procps,
          libkvm-dev [kfreebsd-any], libsensors-dev [linux-any], ${misc:Depends},
          libpci-dev
+Recommends: libsnmp-perl
 Description: SNMP (Simple Network Management Protocol) development files
  The Simple Network Management Protocol (SNMP) provides a framework
  for the exchange of management information between agents (servers)

git diff -U10 sergiodj/lp1946877/old/debian..sergiodj/lp1946877/new/debian -- debian/control

That's adding Recommends: libsnmp-perl to libsnmp-dev. libsnmp-perl is in universe, and libsnmp-dev is in main. I don't think that's allowed, we will have to change that to Suggests afaik, can you confirm? I'll flip this to "needs fixing" until you analyze it.

So the new dependency is
 libsnmp-dev | 5.9+dfsg-3ubuntu4 | jammy | amd64, arm64, armhf, i386, ppc64el, riscv64, s390x
to
 libsnmp-perl | 5.9+dfsg-3ubuntu4 | jammy/universe | amd64, arm64, armhf, i386, ppc64el, riscv64, s390x

But the only reason to have libsnmp-dev:

$ reverse-depends --release jammy libsnmp-dev
Reverse-Depends
* libgvm-dev
* libifstat-dev

Is because -dev and -doc are auto-included by germinate unless you do something about it.

See
https://people.canonical.com/~ubuntu-archive/germinate-output/ubuntu.jammy/all

libsnmp-dev | net-snmp | Rescued from net-snmp | Ubuntu Developers <email address hidden> | 205104 | 1282

Whenever you see rescued that is due to the auto-inclusion.
We can handle that without delta on the package by adding an extra-exclude to

https://git.launchpad.net/~ubuntu-core-dev/ubuntu-seeds/+git/ubuntu/tree/supported#n124
We can review that change in the team and push it (core-dev) then this won't be a problem on upload.

On Wednesday, January 12 2022, Christian Ehrhardt  wrote:

> So the new dependency is
> libsnmp-dev | 5.9+dfsg-3ubuntu4 | jammy | amd64, arm64, armhf, i386, ppc64el, riscv64, s390x
> to
> libsnmp-perl | 5.9+dfsg-3ubuntu4 | jammy/universe | amd64, arm64, armhf, i386, ppc64el, riscv64, s390x

Thank you for catching this, Andreas. And thank you Christian for the
further explanation.

> But the only reason to have libsnmp-dev:
>
> $ reverse-depends --release jammy libsnmp-dev
> Reverse-Depends
> * libgvm-dev
> * libifstat-dev
>
> Is because -dev and -doc are auto-included by germinate unless you do something about it.
>
> See
> https://people.canonical.com/~ubuntu-archive/germinate-output/ubuntu.jammy/all
>
> libsnmp-dev | net-snmp | Rescued from net-snmp | Ubuntu Developers
> <email address hidden> | 205104 | 1282
>
> Whenever you see rescued that is due to the auto-inclusion.
> We can handle that without delta on the package by adding an extra-exclude to
>
> https://git.launchpad.net/~ubuntu-core-dev/ubuntu-seeds/+git/ubuntu/tree/supported#n124
> We can review that change in the team and push it (core-dev) then this won't be a problem on upload.

Ah, got it. I will file an MP against the ubuntu-seeds/+git/ubuntu repo
and mark you guys to review it.

Thanks,

--
Sergio
GPG key ID: E92F D0B3 6B14 F1F4 D8E0 EB2F 106D A1C8 C3CB BF14

On Wednesday, January 12 2022, Sergio Durigan Junior wrote:

> Ah, got it. I will file an MP against the ubuntu-seeds/+git/ubuntu repo
> and mark you guys to review it.

MP filed: https://code.launchpad.net/~sergiodj/ubuntu-seeds/+git/ubuntu/+merge/414063

--
Sergio
GPG key ID: E92F D0B3 6B14 F1F4 D8E0 EB2F 106D A1C8 C3CB BF14

Alright, now that the ubuntu-seeds MP has been merged, I think it is OK to proceed with this one.

Andreas, I talked to Christian during standup and he's happy with the MP. Judging from your comments, I understand that you were a +1 modulo the libsnmp-perl thing, which has since been resolved. Therefore, I'm going to go ahead and upload the package. Thanks both of you for the reviews.

$ dput net-snmp_5.9.1+dfsg-1ubuntu1_source.changes
Trying to upload package to ubuntu
Checking signature on .changes
gpg: /home/sergio/work/net-snmp/net-snmp_5.9.1+dfsg-1ubuntu1_source.changes: Valid signature from 106DA1C8C3CBBF14
Checking signature on .dsc
gpg: /home/sergio/work/net-snmp/net-snmp_5.9.1+dfsg-1ubuntu1.dsc: Valid signature from 106DA1C8C3CBBF14
Uploading to ubuntu (via ftp to upload.ubuntu.com):
  Uploading net-snmp_5.9.1+dfsg-1ubuntu1.dsc: done.
  Uploading net-snmp_5.9.1+dfsg.orig.tar.xz: done.
  Uploading net-snmp_5.9.1+dfsg-1ubuntu1.debian.tar.xz: done.
  Uploading net-snmp_5.9.1+dfsg-1ubuntu1_source.buildinfo: done.
  Uploading net-snmp_5.9.1+dfsg-1ubuntu1_source.changes: done.
Successfully uploaded packages.

yes, should be good

This migrated a long time ago, could you please set the MP status to "merged"?

On Monday, March 07 2022, Andreas Hasenack wrote:

> This migrated a long time ago, could you please set the MP status to "merged"?

Done, thanks.

--
Sergio
GPG key ID: E92F D0B3 6B14 F1F4 D8E0 EB2F 106D A1C8 C3CB BF14