Ubuntu
exim4 package

Merge ~sergiodj/ubuntu/+source/exim4:bug1974214-segfault-smtp-delivery-KINETIC into ubuntu/+source/exim4:ubuntu/devel

  1. Git
  2. lp:~sergiodj/ubuntu/+source/exim4
  3. bug1974214-segfault-smtp-delivery-KINETIC
  4. Merge into ubuntu/devel
Proposed by Sergio Durigan Junior
Status: Needs review
Proposed branch: ~sergiodj/ubuntu/+source/exim4:bug1974214-segfault-smtp-delivery-KINETIC
Merge into: ubuntu/+source/exim4:ubuntu/devel
Diff against target: 247 lines (+219/-0)
4 files modified
debian/changelog (+7/-0)
debian/patches/lp1974214-segfault-smtp-delivery-01.patch (+186/-0)
debian/patches/lp1974214-segfault-smtp-delivery-02.patch (+24/-0)
debian/patches/series (+2/-0)
Reviewer Review Type Date Requested Status
Bryce Harrington (community) Approve
Canonical Server packageset reviewers Pending
Review via email: mp+423962@code.staging.launchpad.net

Description of the change

This MP fixes bug #1974214 in Kinetic, which is about exim4 segfaulting while connecting to the secondary MX after the primary MX has deferred the email delivery.

This has been reported and fixed upstream, and the Ubuntu bug reporter already tried these patches and confirmed that they work. It took me a bit of time to come up with a reproducer, but after some failed attempts I was finally able to write step-by-step instructions. You can find them in the bug description, which is an SRU template (since this bug also affects Jammy).

There are two patches required to fix the bug, but they are not complex and shouldn't require too much review time. The annoying part is really reproducing the bug.

Debian's exim4 has already been fixed in 4.95-6. When we merge it, we can drop these patches from our package.

You can also find a PPA with the proposed package here:

https://launchpad.net/~sergiodj/+archive/ubuntu/exim4

The build is still running; when it finishes I'll trigger autopkgtests and post the results here.

To post a comment you must log in.
Revision history for this message
Sergio Durigan Junior (sergiodj) wrote :

autopkgtest is OK:

autopkgtest [23:36:45]: @@@@@@@@@@@@@@@@@@@@ summary
basic PASS

https://autopkgtest.ubuntu.com/results/autopkgtest-kinetic-sergiodj-exim4/?format=plain

Reply
Revision history for this message
Bryce Harrington (bryce) wrote :

Will take your word on reproduction of the failure, but the patches themselves LGTM, and verified the builds and tests look good. Given we'll be receiving these fixes for kinetic via merge before too long, including these in kinetic seems a no brainer.

The SRU text on LP: #1974214 looks good, although I didn't verify the Test Plan. For the Where Problems Could Occur section, make sure to describe the style of issues to watch for, i.e. crashes or behavioral changes regarding message sending when TLS is in use. In general, a description of how the issue was fixed is considered optional for SRU purposes but in this specific case I think it might be of some usefulness, so perhaps consider explaining briefly that the first patch hangs onto the credentials for the second attempt, and the second patch resets the headers.

Otherwise LGTM, +1.

review: Approve
Reply
Revision history for this message
Bryce Harrington (bryce) wrote :

(Sorry, forgot to manually claim the review slot, please re-add canonical-server.)

Reply
Revision history for this message
Sergio Durigan Junior (sergiodj) wrote :

On Friday, June 03 2022, Bryce Harrington wrote:

> Will take your word on reproduction of the failure, but the patches
> themselves LGTM, and verified the builds and tests look good. Given
> we'll be receiving these fixes for kinetic via merge before too long,
> including these in kinetic seems a no brainer.

Thanks for the review, Bryce.

Uploaded:

$ dput exim4_4.95-4ubuntu3_source.changes
Trying to upload package to ubuntu
Checking signature on .changes
gpg: /home/sergio/work/exim4/exim4_4.95-4ubuntu3_source.changes: Valid signature from 106DA1C8C3CBBF14
Checking signature on .dsc
gpg: /home/sergio/work/exim4/exim4_4.95-4ubuntu3.dsc: Valid signature from 106DA1C8C3CBBF14
Uploading to ubuntu (via ftp to upload.ubuntu.com):
  Uploading exim4_4.95-4ubuntu3.dsc: done.
  Uploading exim4_4.95-4ubuntu3.debian.tar.xz: done.
  Uploading exim4_4.95-4ubuntu3_source.buildinfo: done.
  Uploading exim4_4.95-4ubuntu3_source.changes: done.
Successfully uploaded packages.

> The SRU text on LP: #1974214 looks good, although I didn't verify the
> Test Plan. For the Where Problems Could Occur section, make sure to
> describe the style of issues to watch for, i.e. crashes or behavioral
> changes regarding message sending when TLS is in use. In general, a
> description of how the issue was fixed is considered optional for SRU
> purposes but in this specific case I think it might be of some
> usefulness, so perhaps consider explaining briefly that the first
> patch hangs onto the credentials for the second attempt, and the
> second patch resets the headers.

I expanded the text a bit, please let me know what you think.

Thanks,

--
Sergio
GPG key ID: E92F D0B3 6B14 F1F4 D8E0 EB2F 106D A1C8 C3CB BF14

Reply

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches