Merge lp://staging/~sergiodj/lp-ftbfs-report/fix-internal-pkgset-team-links into lp://staging/~wgrant/lp-ftbfs-report/production
Proposed by
Sergio Durigan Junior
| Status: | Needs review |
|---|---|
| Proposed branch: | lp://staging/~sergiodj/lp-ftbfs-report/fix-internal-pkgset-team-links |
| Merge into: | lp://staging/~wgrant/lp-ftbfs-report/production |
| Diff against target: |
33 lines (+4/-4) 1 file modified
source/build_status.html (+4/-4) |
| To merge this branch: | bzr merge lp://staging/~sergiodj/lp-ftbfs-report/fix-internal-pkgset-team-links |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| William Grant | Pending | ||
|
Review via email:
|
|||
Description of the change
When the packageset and the team names are the same, the internal links for each of these will end up also being the same. Currently, because the packageset section comes first in the page, that means that the team internal link will point to it.
A simple fix is to use distinct suffixes to compose the internal link names, which help differentiate them.
To post a comment you must log in.
Unmerged revisions
- 65. By Sergio Durigan Junior
-
Use suffixes for pkgset and team internal links
When a packageset has the same name of a team, the internal links will
point to the same place, which currently is the packageset section
(because it comes first in the page). We can solve that by using
distinct suffixes when creating the links.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
