Merge lp://staging/~sergei.glushchenko/percona-xtrabackup/2.2-xb-bug1391041 into lp://staging/percona-xtrabackup/2.2

Proposed by Sergei Glushchenko
Status: Merged
Approved by: Alexey Kopytov
Approved revision: no longer in the source branch.
Merged at revision: 5049
Proposed branch: lp://staging/~sergei.glushchenko/percona-xtrabackup/2.2-xb-bug1391041
Merge into: lp://staging/percona-xtrabackup/2.2
Diff against target: 191 lines (+95/-12)
6 files modified
storage/innobase/xtrabackup/doc/source/howtos/recipes_ibkx_gtid.rst (+2/-2)
storage/innobase/xtrabackup/innobackupex.pl (+16/-6)
storage/innobase/xtrabackup/test/t/bug1391041.sh (+73/-0)
storage/innobase/xtrabackup/test/t/bug977101.sh (+2/-2)
storage/innobase/xtrabackup/test/t/gtid.sh (+1/-1)
storage/innobase/xtrabackup/test/t/ib_slave_info.sh (+1/-1)
To merge this branch: bzr merge lp://staging/~sergei.glushchenko/percona-xtrabackup/2.2-xb-bug1391041
Reviewer Review Type Date Requested Status
Alexey Kopytov (community) Approve
Review via email: mp+243264@code.staging.launchpad.net

Description of the change

Bug 1391041: innobackupex should skip GTID output is GTID_MODE is OFF

For MySQL:

1. If GTID_MODE is ON print only GTID of the last change
2. If GTID_MODE is OFF print filename and position

For MariaDB always print filename, position and GTID,
because MariaDB can be easily switched between GTID and
non-GTID and both file/pos and GTID are up to date.

http://jenkins.percona.com/view/PXB%202.2/job/percona-xtrabackup-2.2-param/252/

To post a comment you must log in.
Revision history for this message
Alexey Kopytov (akopytov) wrote :

Sergei,

What about xtrabackup_binlog_info? As in, why does it still contain both GTID and non-GTID coordinates regardless of gtid_mode?

review: Needs Information
Revision history for this message
Sergei Glushchenko (sergei.glushchenko) wrote :

It's a fair question. I modified the code and docs to leave xtrabackup_binlog_info with only GTID or non-GTID, but not both.
http://jenkins.percona.com/view/PXB%202.2/job/percona-xtrabackup-2.2-param/256/

Revision history for this message
Alexey Kopytov (akopytov) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches