Merge lp://staging/~sergei.glushchenko/percona-xtrabackup/2.1-xb-bug1222062 into lp://staging/percona-xtrabackup/2.1

Proposed by Sergei Glushchenko
Status: Merged
Approved by: Alexey Kopytov
Approved revision: no longer in the source branch.
Merged at revision: 764
Proposed branch: lp://staging/~sergei.glushchenko/percona-xtrabackup/2.1-xb-bug1222062
Merge into: lp://staging/percona-xtrabackup/2.1
Diff against target: 631 lines (+109/-41)
13 files modified
doc/source/innobackupex/innobackupex_option_reference.rst (+4/-0)
doc/source/xtrabackup_bin/xbk_option_reference.rst (+4/-0)
innobackupex.pl (+11/-1)
patches/innodb51.patch (+10/-8)
patches/innodb55.patch (+9/-7)
patches/innodb56.patch (+7/-5)
patches/xtradb51.patch (+9/-7)
patches/xtradb55.patch (+10/-8)
src/fil_cur.cc (+1/-1)
src/xtrabackup.cc (+14/-1)
test/inc/common.sh (+4/-1)
test/run.sh (+15/-2)
test/t/bug1222062.sh (+11/-0)
To merge this branch: bzr merge lp://staging/~sergei.glushchenko/percona-xtrabackup/2.1-xb-bug1222062
Reviewer Review Type Date Requested Status
Alexey Kopytov (community) Approve
Review via email: mp+233639@code.staging.launchpad.net

Description of the change

Bug 1222062: Add an option to disable opening all tablespaces on backup start

Introduce xtrabackup option --close-file-handlers to close file
handlers when they aren't needed anymore. Introduce new option -x
for run.sh to force xtrabackup options for all tests by putting them
into [xtrabackup] section of my.cnf.

Two jenkins runs with and without --close-file-handlers, ddl.sh fails as expected

http://jenkins.percona.com/view/PXB%202.1/job/percona-xtrabackup-2.1-param-new/7/
http://jenkins.percona.com/view/PXB%202.1/job/percona-xtrabackup-2.1-param-new/9/

To post a comment you must log in.
Revision history for this message
Alexey Kopytov (akopytov) wrote :

Sergei,

- I would call the option just ‘--close-files’, because ‘handlers’ looks
  confusing (and should be ‘handles’ for that matter).
- users are generally not supposed to call xtrabackup directly, but use
  innobackupex instead. Why is there no corresponding innobackupex
  option?
- please add the warning to the built-in help for xtrabackup option
- please also update the docs (with the “use at your own risk” warning )
- the ‘-i’ option to run.sh has been added to usage text, but is not
  actually handled
- XB_EXTRA_ARGS in run.sh is unused
- srv_close_file_handlers should be initialized to FALSE for consistency

review: Needs Fixing
Revision history for this message
Alexey Kopytov (akopytov) wrote :

In the warning text, I would also explain the consequences briefly, rather than refer users to a bug with a long discussion.

Revision history for this message
Sergei Glushchenko (sergei.glushchenko) wrote :

Hi Alexey,

All comments are reasonable. I just want to explain why I haven't implement option for innobackupex. We don't recommend to use this option and normally user will not use it. However, if he need it badly, then he actually nows what he is doing. So there is an option for him to add it into my.cnf. Isn't it enough?

Revision history for this message
Alexey Kopytov (akopytov) wrote :

Sure, but what if a user hits the open files limit, but still wants to create full backups with mysql.* and other MyISAM tables, buffer pool dumps, etc.?

Revision history for this message
Sergei Glushchenko (sergei.glushchenko) wrote :

He can put the option into [xtrabackup] of my.cnf, it will work file. Anyways I already added the corresponding innobackupex option.

Revision history for this message
Alexey Kopytov (akopytov) wrote :

I'd be very cautious to put such an option to my.cnf. It's too easy to forget and replicate it to another server, for example. Anyway, now the users are free to choose how they want to use it. Thanks.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches