Merge lp://staging/~sergei.glushchenko/percona-xtrabackup/2.1-xb-bug1222062 into lp://staging/percona-xtrabackup/2.1
Proposed by
Sergei Glushchenko
Status: | Merged |
---|---|
Approved by: | Alexey Kopytov |
Approved revision: | no longer in the source branch. |
Merged at revision: | 764 |
Proposed branch: | lp://staging/~sergei.glushchenko/percona-xtrabackup/2.1-xb-bug1222062 |
Merge into: | lp://staging/percona-xtrabackup/2.1 |
Diff against target: |
631 lines (+109/-41) 13 files modified
doc/source/innobackupex/innobackupex_option_reference.rst (+4/-0) doc/source/xtrabackup_bin/xbk_option_reference.rst (+4/-0) innobackupex.pl (+11/-1) patches/innodb51.patch (+10/-8) patches/innodb55.patch (+9/-7) patches/innodb56.patch (+7/-5) patches/xtradb51.patch (+9/-7) patches/xtradb55.patch (+10/-8) src/fil_cur.cc (+1/-1) src/xtrabackup.cc (+14/-1) test/inc/common.sh (+4/-1) test/run.sh (+15/-2) test/t/bug1222062.sh (+11/-0) |
To merge this branch: | bzr merge lp://staging/~sergei.glushchenko/percona-xtrabackup/2.1-xb-bug1222062 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Alexey Kopytov (community) | Approve | ||
Review via email:
|
Description of the change
Bug 1222062: Add an option to disable opening all tablespaces on backup start
Introduce xtrabackup option --close-
handlers when they aren't needed anymore. Introduce new option -x
for run.sh to force xtrabackup options for all tests by putting them
into [xtrabackup] section of my.cnf.
Two jenkins runs with and without --close-
http://
http://
To post a comment you must log in.
Sergei,
- I would call the option just ‘--close-files’, because ‘handlers’ looks file_handlers should be initialized to FALSE for consistency
confusing (and should be ‘handles’ for that matter).
- users are generally not supposed to call xtrabackup directly, but use
innobackupex instead. Why is there no corresponding innobackupex
option?
- please add the warning to the built-in help for xtrabackup option
- please also update the docs (with the “use at your own risk” warning )
- the ‘-i’ option to run.sh has been added to usage text, but is not
actually handled
- XB_EXTRA_ARGS in run.sh is unused
- srv_close_