Merge lp://staging/~sergei.glushchenko/percona-pam-for-mysql/pam-bug1190662 into lp://staging/percona-pam-for-mysql

Proposed by Sergei Glushchenko
Status: Merged
Approved by: Laurynas Biveinis
Approved revision: 31
Merged at revision: 31
Proposed branch: lp://staging/~sergei.glushchenko/percona-pam-for-mysql/pam-bug1190662
Merge into: lp://staging/percona-pam-for-mysql
Diff against target: 107 lines (+14/-12)
2 files modified
src/auth_mapping.c (+8/-8)
src/auth_mapping.h (+6/-4)
To merge this branch: bzr merge lp://staging/~sergei.glushchenko/percona-pam-for-mysql/pam-bug1190662
Reviewer Review Type Date Requested Status
Laurynas Biveinis (community) Approve
Review via email: mp+169250@code.staging.launchpad.net

Description of the change

Fix compiler warnings in auth_mapping.c

To post a comment you must log in.
Revision history for this message
Laurynas Biveinis (laurynas-biveinis) wrote :

Wouldn't a proper fix be to declare token::token_len and mapping_iter::value_len to be size_t?

review: Needs Fixing
Revision history for this message
Sergei Glushchenko (sergei.glushchenko) wrote :

Yes, this is better. Done.

Revision history for this message
Laurynas Biveinis (laurynas-biveinis) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches