Ubuntu
lxc package

Merge lp://staging/~serge-hallyn/ubuntu/trusty/lxc/lxc-chmod-cache into lp://staging/~ubuntu-branches/ubuntu/trusty/lxc/trusty

  1. Trusty (14.04)
  2. lxc-chmod-cache
  3. Merge into trusty
Proposed by Serge Hallyn
Status: Merged
Merge reported by: Stéphane Graber
Merged at revision: not available
Proposed branch: lp://staging/~serge-hallyn/ubuntu/trusty/lxc/lxc-chmod-cache
Merge into: lp://staging/~ubuntu-branches/ubuntu/trusty/lxc/trusty
Diff against target: 53 lines (+25/-0)
3 files modified
debian/changelog (+10/-0)
debian/lxc.postinst (+9/-0)
debian/rules (+6/-0)
To merge this branch: bzr merge lp://staging/~serge-hallyn/ubuntu/trusty/lxc/lxc-chmod-cache
Reviewer Review Type Date Requested Status
Stéphane Graber Pending
Review via email: mp+192914@code.staging.launchpad.net
To post a comment you must log in.
Revision history for this message
Stéphane Graber (stgraber) wrote :

So I think we should do that for /var/cache/lxc too (to avoid people being able to run an outdated buggy setuid binary).

Also, can't you do that from the existing override_dh_install target (you may have to mkdir -p the path from there)?

Revision history for this message
Serge Hallyn (serge-hallyn) wrote :

I had tried from the existing override_dh_install, at the end. That did not work. To make sure I just added the mkdir before it, and still get

drwxr-xr-x 1 ubuntu ubuntu 0 Oct 28 20:41 lxc

(re-build the package and did dpkg -x to look at the package contents).

Good point about the cache - I'd just remembered that as I was writing the SRU test case.

lp://staging/~serge-hallyn/ubuntu/trusty/lxc/lxc-chmod-cache updated
306. By Serge Hallyn

update: also address /var/cache/lxc

Revision history for this message
Stéphane Graber (stgraber) wrote :

Alright, looks good then.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: