Ubuntu
libvirt package

Merge lp://staging/~serge-hallyn/ubuntu/natty/libvirt/upstart-include-default into lp://staging/ubuntu/natty/libvirt

  1. Natty (11.04)
  2. upstart-include-default
  3. Merge into natty
Proposed by Serge Hallyn
Status: Merged
Merged at revision: 112
Proposed branch: lp://staging/~serge-hallyn/ubuntu/natty/libvirt/upstart-include-default
Merge into: lp://staging/ubuntu/natty/libvirt
Diff against target: 38 lines (+14/-1)
2 files modified
debian/changelog (+9/-0)
debian/libvirt-bin.upstart (+5/-1)
To merge this branch: bzr merge lp://staging/~serge-hallyn/ubuntu/natty/libvirt/upstart-include-default
Reviewer Review Type Date Requested Status
Serge Hallyn Needs Resubmitting
Clint Byrum (community) Needs Fixing
Ubuntu Sponsors Pending
Review via email: mp+47850@code.staging.launchpad.net
To post a comment you must log in.
Revision history for this message
Clint Byrum (clint-fewbar) wrote :

Couple things that I think need fixing here:

I think it would be good to add a comment and changelog explanation that this is only there until there is a clear way for maintainer scripts to copy the /etc/default file in as an override in order to deprecate it.

You also need to set a default value for the options with this:

env libvirtd_options="-d"

So that the default file isn't needed at all anymore.

review: Needs Fixing
lp://staging/~serge-hallyn/ubuntu/natty/libvirt/upstart-include-default updated
113. By Serge Hallyn

Address feedback from Clint.

Have upstart job source /etc/default/libvirt-bin. This is only a
temporary fix until upstart provides proper default override support
through /etc/init/libvirt-bin.override (or any other mechanism).
(LP: #708172)

Revision history for this message
Serge Hallyn (serge-hallyn) wrote :

Thanks for the review, Clint. Feedback should be addressed now with the latest push.

review: Needs Resubmitting

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: