Merge lp://staging/~sequba/millenniumduel/widgets-margin into lp://staging/millenniumduel

Proposed by Jakub Sękowski
Status: Merged
Approved by: Jakub Sękowski
Approved revision: 28
Merged at revision: 26
Proposed branch: lp://staging/~sequba/millenniumduel/widgets-margin
Merge into: lp://staging/millenniumduel
Diff against target: 687 lines (+146/-129)
20 files modified
src/IBox.cpp (+5/-5)
src/IBox.hpp (+1/-7)
src/IDrawable.cpp (+38/-13)
src/IDrawable.hpp (+32/-14)
src/IOrderedContainer.cpp (+0/-2)
src/IOrderedContainer.hpp (+0/-7)
src/WButton.cpp (+3/-3)
src/WButton.hpp (+8/-5)
src/WFixed.cpp (+3/-3)
src/WFixed.hpp (+9/-5)
src/WHBox.cpp (+9/-10)
src/WHBox.hpp (+5/-4)
src/WImage.cpp (+2/-2)
src/WImage.hpp (+2/-3)
src/WLabel.cpp (+3/-5)
src/WLabel.hpp (+4/-3)
src/WLayeredView.cpp (+3/-16)
src/WLayeredView.hpp (+5/-8)
src/WVBox.cpp (+9/-10)
src/WVBox.hpp (+5/-4)
To merge this branch: bzr merge lp://staging/~sequba/millenniumduel/widgets-margin
Reviewer Review Type Date Requested Status
Rafał Cieślak Approve
Review via email: mp+177284@code.staging.launchpad.net

Description of the change

Bug #1204286 fix. I've achieve this in exactly the way specified here: https://bugs.launchpad.net/millenniumduel/+bug/1204286/comments/3

To post a comment you must log in.
27. By Jakub Sękowski

fixed problem with left and bottom margin and changed some variables names to avoid similar misunderstandings later on

28. By Jakub Sękowski

removed some redundant allegro transformations

Revision history for this message
Rafał Cieślak (rafalcieslak256) wrote :

This looks perfect. Thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches