DockManager

Merge lp://staging/~seif/dockmanager/enhance-zeitgeist-menus into lp://staging/dockmanager

enhance-zeitgeist-menus
Merge into trunk

Proposed by Seif Lotfy on 2010-12-14

Status:	Merged
Merged at revision:	80
Proposed branch:	lp://staging/~seif/dockmanager/enhance-zeitgeist-menus
Merge into:	lp://staging/dockmanager
Diff against target:	271 lines (+129/-88) 1 file modified scripts/zeitgeist_menus.py (+129/-88)
To merge this branch:	bzr merge lp://staging/~seif/dockmanager/enhance-zeitgeist-menus
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Rico Tzschichholz		2010-12-14	Approve on 2010-12-20
Review via email: mp+43714@code.staging.launchpad.net

Description of the change

I enhanced the menus by allowing them to update themselves on the fly using the zeitgeist monitors as well as use reduce memory consumption by using negations in queries (no need to ask for all events)

Revision history for this message

Rico Tzschichholz (ricotz) wrote on 2010-12-15:

Nice to see you working on it :)

But the version check isn't working the current natty version 0.5.2 doesn't fit the check. Also the added items aren't right. So currently it is quite broken for me :(

review: Needs Fixing

Revision history for this message

Seif Lotfy (seif) wrote on 2010-12-15:

ah Shit I know why. There is a bug in Zeitgeist that did not get released.
Let me work aroudn that.

On Wed, Dec 15, 2010 at 8:17 AM, Rico Tzschichholz <email address hidden>wrote:

> Review: Needs Fixing
> Nice to see you working on it :)
>
> But the version check isn't working the current natty version 0.5.2 doesn't
> fit the check. Also the added items aren't right. So currently it is quite
> broken for me :(
>
>
> --
>
> https://code.launchpad.net/~seif/dockmanager/enhance-zeitgeist-menus/+merge/43714
> You are the owner of lp:~seif/dockmanager/enhance-zeitgeist-menus.
>

--
This is me doing some advertisement for my blog http://seilo.geekyogre.com

Revision history for this message

Seif Lotfy (seif) wrote on 2010-12-16:

The remaining issue is from you side guys. I finished my part.

lp://staging/~seif/dockmanager/enhance-zeitgeist-menus updated on 2010-12-19

78. By Robert Dyer on 2010-12-19: fix the add_menu_with_uri calls to properly fall back on add_menu_item

Revision history for this message

Rico Tzschichholz (ricotz) wrote on 2010-12-19:

The menu_pressed method need some work. Now it will throw a exception in too many cases and if it fails it might not use the right application.
I think it is better to use:

if uri.endswith(".desktop"):
    try:
        appinfo = gio.unix.DesktopAppInfo(uri)
        if appinfo:
            appinfo.launch(self.ids[menu_id]])
    except ...

review: Needs Fixing

lp://staging/~seif/dockmanager/enhance-zeitgeist-menus updated on 2010-12-20

79. By Robert Dyer on 2010-12-20: better code

Revision history for this message

Rico Tzschichholz (ricotz) on 2010-12-20:

review: Approve

lp://staging/~seif/dockmanager/enhance-zeitgeist-menus updated on 2010-12-20

80. By Rico Tzschichholz on 2010-12-20

update zeitgeist-menu-helper

enhanced the menus by allowing them to update themselves on the fly
using the zeitgeist monitors as well as use reduce memory consumption
by using negations in queries (no need to ask for all events

merge lp:~seif/dockmanager/enhance-zeitgeist-menus