Wingpanel Bluetooth Indicator

Merge lp://staging/~seesemichaelj/wingpanel-indicator-bluetooth/bluetooth-switchboard-access-from-lock into lp://staging/~wingpanel-devs/wingpanel-indicator-bluetooth/trunk

  1. bluetooth-switchboard-access-from-lock
  2. Merge into trunk
Proposed by Mike Seese
Status: Merged
Approved by: Felipe Escoto
Approved revision: 31
Merged at revision: 26
Proposed branch: lp://staging/~seesemichaelj/wingpanel-indicator-bluetooth/bluetooth-switchboard-access-from-lock
Merge into: lp://staging/~wingpanel-devs/wingpanel-indicator-bluetooth/trunk
Diff against target: 138 lines (+28/-11)
4 files modified
src/Indicator.vala (+8/-4)
src/Widgets/PopoverWidget.vala (+3/-3)
src/Widgets/Views/DiscoveryView.vala (+11/-0)
src/Widgets/Views/MainView.vala (+6/-4)
To merge this branch: bzr merge lp://staging/~seesemichaelj/wingpanel-indicator-bluetooth/bluetooth-switchboard-access-from-lock
Reviewer Review Type Date Requested Status
Adam Bieńkowski (community) code Approve
Review via email: mp+285824@code.staging.launchpad.net

Commit message

Hide settings and Discovery button in greeter

Description of the change

Disables "Discover Devices..." and "Bluetooth Settings..." when in Greeter

To post a comment you must log in.
lp://staging/~seesemichaelj/wingpanel-indicator-bluetooth/bluetooth-switchboard-access-from-lock updated
29. By Mike Seese

Removed redundant is_in_session variables and disable showing separator in Greeter

Revision history for this message
Adam Bieńkowski (donadigo) wrote :

Code: looks fine.

review: Approve (code)
lp://staging/~seesemichaelj/wingpanel-indicator-bluetooth/bluetooth-switchboard-access-from-lock updated
30. By Mike Seese

Disable visibility of Discovery View when not active. It allocates space otherwise regardless that it is not shown.

31. By Mike Seese

Moved visibility funcs inside of DiscoveryView. discovery_view.start_discovery() enables visibility and thus must be called before set_visisble_child.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: