Software Updater

Merge lp://staging/~seb128/update-manager/livepatch-settings-installed into lp://staging/update-manager

livepatch-settings-installed
Merge into main

Proposed by Sebastien Bacher on 2020-01-08

Status:	Merged
Merged at revision:	2900
Proposed branch:	lp://staging/~seb128/update-manager/livepatch-settings-installed
Merge into:	lp://staging/update-manager
Diff against target:	23 lines (+7/-0) 1 file modified UpdateManager/Dialogs.py (+7/-0)
To merge this branch:	bzr merge lp://staging/~seb128/update-manager/livepatch-settings-installed
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Ubuntu Core Development Team		2020-01-08	Pending
Review via email: mp+377294@code.staging.launchpad.net

Commit message

Don't mention livepatch settings when the interface is not installed

Description of the change

Don't mention livepatch settings when the interface is not installed

Revision history for this message

Brian Murray (brian-murray) wrote on 2020-01-08:

This looks good to me but I'm curious - what provides the "software-properties-livepatch.desktop" setting /file?

Revision history for this message

Sebastien Bacher (seb128) wrote on 2020-01-08:

hum, that's a good question. the .desktop/UI is shipped with software-properties-gtk but if that's not installed there is no point having a settings button and that's not specific to livepatch...

lp://staging/~seb128/update-manager/livepatch-settings-installed updated on 2020-11-30

2860. By Sebastien Bacher on 2020-11-30: rebase on trunk
2861. By Sebastien Bacher on 2020-11-30: check for livepatch the same way as software properties

Revision history for this message

Sebastien Bacher (seb128) wrote on 2020-11-30:

Ok, I finally got to revisit that patch, as your comment pointed out checking for a .desktop from the same source wasn't really useful. What software-properties is doing [1] is to check that the online accounts are available or not. There is already a condition on software-properties to be available, so the change as suggested now show allow the UIs to have a synced state

[1] https://git.launchpad.net/software-properties/tree/softwareproperties/gtk/utils.py#n50