Merge lp://staging/~seb128/ubuntu-system-settings/dont-install-example into lp://staging/ubuntu-system-settings

Proposed by Sebastien Bacher
Status: Merged
Approved by: Ken VanDine
Approved revision: 82
Merged at revision: 84
Proposed branch: lp://staging/~seb128/ubuntu-system-settings/dont-install-example
Merge into: lp://staging/ubuntu-system-settings
Diff against target: 43 lines (+1/-13)
3 files modified
debian/control (+1/-10)
debian/ubuntu-system-settings-example.install (+0/-2)
plugins/plugins.pro (+0/-1)
To merge this branch: bzr merge lp://staging/~seb128/ubuntu-system-settings/dont-install-example
Reviewer Review Type Date Requested Status
Ken VanDine Approve
PS Jenkins bot continuous-integration Approve
Review via email: mp+172103@code.staging.launchpad.net

Commit message

don't install the example plugin, it's useful as source example,
not so much installed (especially since we have other working plugins)

Description of the change

don't install the example plugin, it's useful as source example,
not so much installed (especially since we have other working plugins)

To post a comment you must log in.
Revision history for this message
Iain Lane (laney) wrote :

You probably want to remove it from plugins/plugins.pro too

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Sebastien Bacher (seb128) wrote :

good point, I dropped it frop the .pro and re-enable the install rules in the example

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Ken VanDine (ken-vandine) wrote :

You should probably make it conflict with the newer version so it gets remove.

review: Needs Fixing
82. By Sebastien Bacher

uncomment install rules, drop example from the project instead

Revision history for this message
Sebastien Bacher (seb128) wrote :

there you go

Revision history for this message
Ken VanDine (ken-vandine) wrote :

Awesome!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches