ubiquity

Merge lp://staging/~seb128/ubiquity/start-screen-reader into lp://staging/ubiquity

start-screen-reader
Merge into trunk

Proposed by Sebastien Bacher on 2018-04-24

Status:	Merged
Merged at revision:	6627
Proposed branch:	lp://staging/~seb128/ubiquity/start-screen-reader
Merge into:	lp://staging/ubiquity
Diff against target:	102 lines (+26/-28) 2 files modified debian/changelog (+8/-1) ubiquity/frontend/gtk_ui.py (+18/-27)
To merge this branch:	bzr merge lp://staging/~seb128/ubiquity/start-screen-reader
Related bugs:	Link a bug report

Reviewer	Date Requested	Status
Iain Lane (community)	2018-04-24	Approve on 2018-04-24
Jean-Baptiste Lallement		Needs Fixing on 2018-04-24
Review via email: mp+343975@code.staging.launchpad.net

Commit message

Don't desactivate the screen-reader desktop keybinding, that was
needed when ubiquity was handling the key press events but now
gsd-media-keys is doing that. Listen to the corresponding key to
start orca under ubiquity-dm since gnome-session isn't there to do it.

Description of the change

Revision history for this message

Iain Lane (laney) wrote on 2018-04-24:

Two nitpicks and one other change requested, but looks mostly good - thanks!

review: Needs Fixing

Revision history for this message

Didier Roche-Tolomelli (didrocks) wrote on 2018-04-24:

I have nothing more to add that the remarks Laney already had. Reading the value calling directly the callback is the best way btw. :)

Revision history for this message

Jean-Baptiste Lallement (jibel) wrote on 2018-04-24:

package fails to build due to pep8 tests

./tests/run-pep8
ubiquity/frontend/gtk_ui.py:161:1: E302 expected 2 blank lines, found 1
ubiquity/frontend/gtk_ui.py:167:1: E302 expected 2 blank lines, found 1
ubiquity/frontend/gtk_ui.py:724:80: E501 line too long (88 > 79 characters)
ubiquity/frontend/gtk_ui.py:725:80: E501 line too long (106 > 79 characters)
ubiquity/frontend/gtk_ui.py:726:1: W293 blank line contains whitespace

review: Needs Fixing

Revision history for this message

Didier Roche-Tolomelli (didrocks) wrote on 2018-04-24:

+1 for me, I trust you testing it, but it looks syntactically good, as long as pep8 passes :)

lp://staging/~seb128/ubiquity/start-screen-reader updated on 2018-04-24

6628. By Sebastien Bacher on 2018-04-24: Tweaks to address the first review comments
6629. By Sebastien Bacher on 2018-04-24: Identation, whitespace and new lines tweaks