Merge lp://staging/~seb128/ubiquity/remove-ecryptfs-option into lp://staging/ubiquity

Thanks for this update.

The object login_encrypt has been removed from the page of the GTK frontend (and initialized to None in the page's constructor) but is still used in ubi-usersetup in on_authentication_toggled(). Ubiquity crashes when the user selects auto-login.

Thanks for catching that, I remove that callback/widget and the corresponding autopilot reference

pep8 tests are failing:
ubiquity/plugins/ubi-usersetup.py:432:1: E302 expected 2 blank lines, found 1
autopilot/ubiquity_autopilot_tests/emulators/gtkcontainers.py:273:1: E302 expected 2 blank lines, found 1

Unit tests are failing:
test_interface_translated (test_gtkui.TestFrontend) ... Exception in GTK frontend (invoking crash handler):
Traceback (most recent call last):
  File "/usr/lib/python3/dist-packages/gi/overrides/Gtk.py", line 103, in _builder_connect_callback
    handler, args = _extract_handler_and_args(obj_or_map, handler_name)
  File "/usr/lib/python3/dist-packages/gi/overrides/Gtk.py", line 83, in _extract_handler_and_args
    raise AttributeError('Handler %s not found' % handler_name)
AttributeError: Handler on_authentication_toggled not found

Traceback (most recent call last):
  File "/usr/lib/python3/dist-packages/gi/overrides/Gtk.py", line 103, in _builder_connect_callback
    handler, args = _extract_handler_and_args(obj_or_map, handler_name)
  File "/usr/lib/python3/dist-packages/gi/overrides/Gtk.py", line 83, in _extract_handler_and_args
    raise AttributeError('Handler %s not found' % handler_name)
AttributeError: Handler on_authentication_toggled not found

This diff fixes the build:
=== modified file 'autopilot/ubiquity_autopilot_tests/emulators/gtkcontainers.py'
--- autopilot/ubiquity_autopilot_tests/emulators/gtkcontainers.py 2018-02-28 11:45:21 +0000
+++ autopilot/ubiquity_autopilot_tests/emulators/gtkcontainers.py 2018-02-28 14:19:21 +0000
@@ -270,6 +270,7 @@
         else:
             return False

+
 class GtkAlignment(GtkContainers):
     """ Emulator class for a GtkAlignment instance """
     def __init__(self, *args):

=== modified file 'gui/gtk/stepUserInfo.ui'
--- gui/gtk/stepUserInfo.ui 2018-02-27 14:28:33 +0000
+++ gui/gtk/stepUserInfo.ui 2018-02-28 14:22:16 +0000
@@ -88,7 +88,6 @@
                 <property name="xalign">0</property>
                 <property name="draw_indicator">True</property>
                 <property name="group">login_pass</property>
- <signal name="clicked" handler="on_authentication_toggled" swapped="no"/>
               </object>
               <packing>
                 <property name="expand">False</property>

=== modified file 'ubiquity/plugins/ubi-usersetup.py'
--- ubiquity/plugins/ubi-usersetup.py 2018-02-28 11:41:07 +0000
+++ ubiquity/plugins/ubi-usersetup.py 2018-02-28 14:19:09 +0000
@@ -429,6 +429,7 @@
         else:
             self.resolver_ok = False

+
 class PageKde(PageBase):
     plugin_breadcrumb = 'ubiquity/text/breadcrumb_user'

with the changes above applied, it builds successfully and manual verification shows that the "encrypt home directory" option is gone and installation is successful.

Approved.