ubiquity

Merge lp://staging/~seb128/ubiquity/new-gsd-binaries into lp://staging/ubiquity

  1. new-gsd-binaries
  2. Merge into trunk
Proposed by Sebastien Bacher
Status: Merged
Approved by: Mathieu Trudel-Lapierre
Approved revision: 6540
Merged at revision: 6546
Proposed branch: lp://staging/~seb128/ubiquity/new-gsd-binaries
Merge into: lp://staging/ubiquity
Diff against target: 49 lines (+19/-5)
2 files modified
bin/ubiquity-dm (+13/-5)
debian/changelog (+6/-0)
To merge this branch: bzr merge lp://staging/~seb128/ubiquity/new-gsd-binaries
Reviewer Review Type Date Requested Status
Iain Lane (community) Approve
Mathieu Trudel-Lapierre Approve
Didier Roche-Tolomelli (community) Approve
Jeremy Bícha Pending
Review via email: mp+327611@code.staging.launchpad.net

Commit message

Update ubiquity-dm for the new gnome-settings-daemon (lp: #1702892)

Description of the change

Update ubiquity-dm for the new gnome-settings-daemon (lp: #1702892)

The list of binaries is something that could be argued over, some are not very useful but could be used in some cases...

To post a comment you must log in.
Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

LGTM, I think the list makes sense (at least, I wouldn't remove any binaries from it) without looking if more is needed.

Didn't spot anything bad python-side wide.

review: Approve
Revision history for this message
Iain Lane (laney) wrote :

Looks good, just one comment inline that you might or might not want to do. (I'm not a reviewer though).

review: Approve
Revision history for this message
Mathieu Trudel-Lapierre (cyphermox) wrote :

Looks fine to me. I added a comment on Laney's comment. I leave the decision for this particular thing to you.

review: Approve
Revision history for this message
Iain Lane (laney) :
lp://staging/~seb128/ubiquity/new-gsd-binaries updated
6541. By Sebastien Bacher

check for the gsd directory rather than a specific binary

Revision history for this message
Sebastien Bacher (seb128) wrote :

new commit up for review

lp://staging/~seb128/ubiquity/new-gsd-binaries updated
6542. By Sebastien Bacher

Rebase on trunk

Revision history for this message
Iain Lane (laney) wrote :

I'm good with that, thanks.

Only concern is that if we move to multiarch paths there it'll stop working, but the full path to the binaries is given in any case, so that will already break.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to status/vote changes: