Merge lp://staging/~seb128/telephony-service/dont-unref-gvariant into lp://staging/telephony-service/rtm-15.04

Proposed by Gustavo Pichorim Boiko
Status: Merged
Approved by: Gustavo Pichorim Boiko
Approved revision: 1040
Merged at revision: 1099
Proposed branch: lp://staging/~seb128/telephony-service/dont-unref-gvariant
Merge into: lp://staging/telephony-service/rtm-15.04
Diff against target: 11 lines (+0/-1)
1 file modified
indicator/messagingmenu.cpp (+0/-1)
To merge this branch: bzr merge lp://staging/~seb128/telephony-service/dont-unref-gvariant
Reviewer Review Type Date Requested Status
Tiago Salem Herrmann Pending
PS Jenkins bot continuous-integration Pending
Review via email: mp+263928@code.staging.launchpad.net

This proposal supersedes a proposal from 2015-03-10.

Commit message

don't unref a non owned variant, g_variant_new_strv() returns a floating
reference which is consumed by calling messaging_menu_message_add_action()
thanks Lars Uebernickel for pointing the issue

Description of the change

don't unref a non owned variant, g_variant_new_strv() returns a floating
reference which is consumed by calling messaging_menu_message_add_action()
thanks Lars Uebernickel for pointing the issue

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal
review: Approve (continuous-integration)
Revision history for this message
Tiago Salem Herrmann (tiagosh) wrote : Posted in a previous version of this proposal

Looks good. Thanks.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches