Merge lp://staging/~seb128/software-properties/use_credential_error into lp://staging/software-properties

Proposed by Sebastien Bacher
Status: Merged
Merged at revision: 1064
Proposed branch: lp://staging/~seb128/software-properties/use_credential_error
Merge into: lp://staging/software-properties
Diff against target: 28 lines (+10/-0)
2 files modified
debian/changelog (+8/-0)
softwareproperties/gtk/DialogAuth.py (+2/-0)
To merge this branch: bzr merge lp://staging/~seb128/software-properties/use_credential_error
Reviewer Review Type Date Requested Status
Andrea Azzarone (community) Approve
Review via email: mp+362179@code.staging.launchpad.net

Commit message

* softwareproperties/gtk/DialogAuth.py:
  - Log call_ensure_credentials_finish errors, fixes the build failing
    due to pyflakes warning about an unused variable

Description of the change

The previous upload fails with that error

test_pyflakes3_clean (tests.test_pyflakes.TestPyflakesClean) ... /<<PKGBUILDDIR>>/.pybuild/cpython3_3.7/build/softwareproperties/gtk/DialogAuth.py:152: local variable 'e' is assigned to but never used
/<<PKGBUILDDIR>>/softwareproperties/gtk/DialogAuth.py:152: local variable 'e' is assigned to but never used
ERROR

To post a comment you must log in.
Revision history for this message
Andrea Azzarone (azzar1) wrote :

LGTM thx!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to status/vote changes: