Merge lp://staging/~seb128/indicator-messages/newer-libglib-deprecations into lp://staging/indicator-messages

Proposed by Sebastien Bacher
Status: Merged
Merged at revision: 462
Proposed branch: lp://staging/~seb128/indicator-messages/newer-libglib-deprecations
Merge into: lp://staging/indicator-messages
Diff against target: 211 lines (+23/-28)
2 files modified
src/im-accounts-service.c (+9/-13)
src/indicator-desktop-shortcuts.c (+14/-15)
To merge this branch: bzr merge lp://staging/~seb128/indicator-messages/newer-libglib-deprecations
Reviewer Review Type Date Requested Status
Sebastien Bacher Approve
Iain Lane (community) Needs Fixing
Review via email: mp+372751@code.staging.launchpad.net

Commit message

* src/im-accounts-service.c, src/indicator-desktop-shortcuts.c:
  - don't use deprecated g_type_class_add_private, fix the build with the
   current libglib version

Description of the change

* src/im-accounts-service.c, src/indicator-desktop-shortcuts.c:
  - don't use deprecated g_type_class_add_private, fix the build with the
   current libglib version

the castings were added to fix those warnings/errors

indicator-desktop-shortcuts.c:72:56: note: expected 'IndicatorDesktopShortcuts * {aka struct _IndicatorDesktopShortcuts *}' but argument is of type 'GObject * {aka struct _GObject *}'
 G_DEFINE_TYPE_WITH_PRIVATE (IndicatorDesktopShortcuts, indicator_desktop_shortcuts, G_TYPE_OBJECT);

To post a comment you must log in.
Revision history for this message
Iain Lane (laney) wrote :

Thanks for fixing this. Mostly good, but just one comment about the proper (GLib) way to do those casts, then feel free to land this yourself. :)

review: Needs Fixing
Revision history for this message
Sebastien Bacher (seb128) wrote :

Thanks, casting and lines split updated, I'm going to merge&upload

review: Approve
462. By Sebastien Bacher

Update casting and line wrapping according to review

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches