Juju Charms Collection
odl-controller package

Merge lp://staging/~sdn-charmers/charms/trusty/odl-controller/odl-cmds into lp://staging/~sdn-charmers/charms/trusty/odl-controller/trunk

  1. Trusty Tahr (14.04)
  2. odl-cmds
  3. Merge into trunk
Proposed by Liam Young
Status: Merged
Merged at revision: 5
Proposed branch: lp://staging/~sdn-charmers/charms/trusty/odl-controller/odl-cmds
Merge into: lp://staging/~sdn-charmers/charms/trusty/odl-controller/trunk
Diff against target: 171 lines (+69/-11)
2 files modified
hooks/odl_controller_hooks.py (+28/-11)
hooks/odl_controller_utils.py (+41/-0)
To merge this branch: bzr merge lp://staging/~sdn-charmers/charms/trusty/odl-controller/odl-cmds
Reviewer Review Type Date Requested Status
SDN Charmers Pending
Review via email: mp+262095@code.staging.launchpad.net
To post a comment you must log in.
Revision history for this message
Liam Young (gnuoy) wrote :

The post install commands that were being run no longer work on more recent versions of ODL because the features being requested have been renamed or removed.

This mp removes any default commands. Instead, a charm joined via the controller-api relation can request features so be installed or log settings to be set by setting odl-cmds to a string representation of json.

eg

{
    'feature:install': ['cosc-cvpn-ovs-rest', 'odl-netconf-connector-all'],
    'log:set': {
        'TRACE': ['cosc-cvpn-ovs-rest', 'odl-netconf-connector-all'],
    }
}

The above would request the installation of cosc-cvpn-ovs-rest and odl-netconf-connector-all and set logging to trace for cosc-cvpn-ovs-rest and odl-netconf-connector-all

Revision history for this message
Liam Young (gnuoy) wrote :

The filter_installed function was added on the assumption that installing features was an expensive operation, it might not be so this may be overkill

Revision history for this message
Robert Ayres (robert-ayres) wrote :

Are you using an auto-formatter? Seems to be some formatting changes that aren't related to functionality.

Revision history for this message
Liam Young (gnuoy) wrote :

I fixed some flake8 complaints while I was at it

lp://staging/~sdn-charmers/charms/trusty/odl-controller/odl-cmds updated
6. By Liam Young

Switch to double quotes for consistency

Revision history for this message
Jason Hobbs (jason-hobbs) wrote :

When using this, port 8080 on the controller isn't listening.

https://ask.opendaylight.org/question/919/resource-error-using-port-8080/

This makes it look like we need: odl-nsf-all and odl-adsal-compatibility installed for port 8080 to come up.

Is there a corresponding branch for neutron-api to issue that that odl-cmds?

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: