Glipper

Merge lp://staging/~sdemchenko/glipper/feature-accelerators into lp://staging/glipper

  1. feature-accelerators
  2. Merge into trunk
Proposed by Stanislav Demchenko
Status: Needs review
Proposed branch: lp://staging/~sdemchenko/glipper/feature-accelerators
Merge into: lp://staging/glipper
Diff against target: 165 lines (+95/-4)
4 files modified
glipper/AppIndicator.py (+26/-2)
glipper/__init__.py (+3/-0)
glipper/plugins/autopaste.py (+62/-0)
glipper/plugins/snippets.py (+4/-2)
To merge this branch: bzr merge lp://staging/~sdemchenko/glipper/feature-accelerators
Reviewer Review Type Date Requested Status
Laszlo Pandy Pending
Review via email: mp+118856@code.staging.launchpad.net

Description of the change

I have added accelerators to history items and to snippet menu and its items.
Also, a new plugin "Auto paste" can accelerate Glipper usage even further (it sends Control+V key stroke to the active window right after an item selection). Just like item accelerators, auto-pasting works both for history and snippets.

To post a comment you must log in.
Revision history for this message
Laszlo Pandy (laszlok) wrote :

> reserved_accelerators = "0acpu" # _0. Snippets, _About, _Clear, _Preferences, Pl_ugins

This won't work. For example, in the French translation, the accelorator for Pl_ugins is "_Greffons".

The only way I see to make it work across languages is to only use numbers for the accelorators.

Reply
Revision history for this message
Stanislav Demchenko (sdemchenko) wrote :

Hi Laszlo, thank you for the tip, I'll try to amend this ASAP.
And I have one more question, about plugin Auto Paste: in that plugin
I rely on a command "xte", which is in Ubuntu package "xautomation",
and I'm undecided if I shall
1) add a dependency on that package (to spare users from manual
installation), or
2) ask users to install xautomation themselves (as I do now in a
message box), because the plugin is optional and people may not want
to have extra dependencies.
I implemented the second option to be conservative, but honestly I
feel it just unnecessarily adds some headache to users, and I should
add a dependency on xautomation.
What is your preference?

On Wed, Aug 15, 2012 at 9:37 AM, Laszlo Pandy <email address hidden> wrote:
>> reserved_accelerators = "0acpu" # _0. Snippets, _About, _Clear, _Preferences, Pl_ugins
>
> This won't work. For example, in the French translation, the accelorator for Pl_ugins is "_Greffons".
>
> The only way I see to make it work across languages is to only use numbers for the accelorators.
> --
> https://code.launchpad.net/~sdemchenko/glipper/feature-accelerators/+merge/118856
> You are the owner of lp:~sdemchenko/glipper/feature-accelerators.

Reply
lp://staging/~sdemchenko/glipper/feature-accelerators updated
121. By Stanislav Demchenko

Replaced hard-coded accelerator characters with their respective internationalized counterparts provided by GTK.

Revision history for this message
Joseph Boiteau (josephboiteau) wrote :

so will that be merged?

I'm quite interested by the auto-paste feature myself, it should be an option to set via the Preferences

Reply

Unmerged revisions

121. By Stanislav Demchenko

Replaced hard-coded accelerator characters with their respective internationalized counterparts provided by GTK.

120. By Stanislav Demchenko

Added 'Auto paste' plugin to emulate Control+V on a history or snippet item selection.

119. By Stanislav Demchenko

Added a space between the accelerator and the label in menu item "Snippets" (for readability).

118. By Stanislav Demchenko

Restored spaces as in trunk to simplify review.
Added 1 extra space between the accelerator character and menu item label to improve readability.

117. By Stanislav Demchenko

Added accelerators for menu items in history and in snippets.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches