Merge lp://staging/~scigghia/stock-logistic-flows/stock-logistic-flows-stock-cancel into lp://staging/stock-logistic-flows

Proposed by Andrea Cometa
Status: Merged
Merged at revision: 34
Proposed branch: lp://staging/~scigghia/stock-logistic-flows/stock-logistic-flows-stock-cancel
Merge into: lp://staging/stock-logistic-flows
Diff against target: 303 lines (+269/-0)
6 files modified
stock_cancel/__init__.py (+24/-0)
stock_cancel/__openerp__.py (+39/-0)
stock_cancel/i18n/it.po (+43/-0)
stock_cancel/i18n/stock_cancel.pot (+43/-0)
stock_cancel/stock.py (+81/-0)
stock_cancel/stock_view.xml (+39/-0)
To merge this branch: bzr merge lp://staging/~scigghia/stock-logistic-flows/stock-logistic-flows-stock-cancel
Reviewer Review Type Date Requested Status
Nicola Riolini - Micronaet (community) Approve
Francesco Apruzzese (community) Approve
Andrea Cometa (community) Approve
Raphaël Valyi - http://www.akretion.com Approve
Lorenzo Battistini (community) tested Approve
Alexandre Fayolle - camptocamp Needs Information
Review via email: mp+167554@code.staging.launchpad.net

Description of the change

[add] stock_cancel for openerp 7

To post a comment you must log in.
29. By Andrea Cometa

merge

Revision history for this message
Alexandre Fayolle - camptocamp (alexandre-fayolle-c2c) wrote :

Hello,

What do you call a 'valuation move'?

review: Needs Information
Revision history for this message
Andrea Cometa (scigghia) wrote :

> Hello,
>
> What do you call a 'valuation move'?

maybe it is better to call it 'Account Move'
the message comes out after a check on account.move

Revision history for this message
Lorenzo Battistini (elbati) wrote :

Hello Alexandre,

here 'valuation moves' mean the account moves generated by real time stock valuation.

So, since the only link between picking and move is the 'ref' field, the module, before reopening the picking, checks if that picking has generated account moves. If so, gives error.

Revision history for this message
Lorenzo Battistini (elbati) wrote :
review: Approve (tested)
Revision history for this message
Raphaël Valyi - http://www.akretion.com (rvalyi) wrote :

Look good to me. A useful module definitely!
may be you can just remove the trash comment in stock_cancel/stock.py line 203 and 204.

review: Approve
30. By Andrea Cometa

[fix] pep8 style and remove comment

Revision history for this message
Andrea Cometa (scigghia) wrote :

ok! i did it :)

review: Approve
Revision history for this message
Francesco Apruzzese (opencode) :
review: Approve
Revision history for this message
Nicola Riolini - Micronaet (nicolariolini) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches