Merge lp://staging/~schwuk/checkbox/cts-iter_4-item_65 into lp://staging/checkbox

Proposed by David Murphy
Status: Merged
Merged at revision: 820
Proposed branch: lp://staging/~schwuk/checkbox/cts-iter_4-item_65
Merge into: lp://staging/checkbox
Diff against target: 118 lines (+66/-9)
2 files modified
jobs/video.txt.in (+24/-0)
scripts/resolution_test (+42/-9)
To merge this branch: bzr merge lp://staging/~schwuk/checkbox/cts-iter_4-item_65
Reviewer Review Type Date Requested Status
Marc Tardif (community) Approve
Review via email: mp+27724@code.staging.launchpad.net

This proposal supersedes a proposal from 2010-06-07.

Description of the change

Part of the Consumer Test Suite, satisfying item 65 (minimum screen resolution).

Expanded resolution_test to (optionally) accept --horizontal and --vertical parameters. If both are supplied (and > 0) then the script does a comparison test and returns an appropriate exit code.

If no arguments are supplied, then the script behaves as it used to (returning, if possible, the screen resolution.

To post a comment you must log in.
Revision history for this message
Marc Tardif (cr3) wrote : Posted in a previous version of this proposal

How come the minimum screen resolution for the GUI installation is 1024x768 whereas the resolution for Ubuntu Netbook Edition is 1024x600? Does that mean it's not possible to perform a GUI installation on a Netbook?

review: Needs Information
Revision history for this message
David Murphy (schwuk) wrote :

Good catch Marc - I hadn't considered UNE.

As discussed on IRC, I've split the test in two: one for desktop, and one for netbook (these are referring to editions, rather than form factors), using the presence of meta packages (ubuntu-desktop and ubuntu-netbook) to differentiate between the two.

Revision history for this message
Marc Tardif (cr3) wrote :

Awesome, looks good!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches