Account - Invoicing

Merge lp://staging/~sbi/account-invoicing/6.1-account_invoice_total into lp://staging/~account-core-editors/account-invoicing/6.1

6.1-account_invoice_total
Merge into 6.1

Proposed by Stéphane Bidoul (Acsone) on 2012-11-19

Status:

Merged

Approved by:

Stefan Rijnhart (Opener) on 2012-12-03

Approved revision:

Merged at revision:

Proposed branch:

lp://staging/~sbi/account-invoicing/6.1-account_invoice_total

Merge into:

lp://staging/~account-core-editors/account-invoicing/6.1

Diff against target:

168 lines (+143/-0)

5 files modified

account_invoice_total/README.md (+21/-0)
account_invoice_total/__init__.py (+25/-0)
account_invoice_total/__openerp__.py (+43/-0)
account_invoice_total/account_invoice_total.py (+38/-0)
account_invoice_total/account_invoice_total_view.xml (+16/-0)

To merge this branch:

bzr merge lp://staging/~sbi/account-invoicing/6.1-account_invoice_total

Low

Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
Joël Grand-Guillaume @ camptocamp		2012-11-19	Approve on 2012-11-20
Review via email: mp+134970@code.staging.launchpad.net

Description of the change

Until OpenERP 6.0.3 when creating a supplier invoice one first had to enter the grand total, this had to match with the computed total before the invoice could be verified.

In OpenERP 6.1 this feature has silently been removed.

This merge proposal provides the account_invoice_total module which brings back the field and the extra verification check.

Discussion : https://bugs.launchpad.net/openobject-addons/+bug/998008
Code Revision : http://bazaar.launchpad.net/~openerp/openobject-addons/trunk/revision/6254

This module was originally created at https://github.com/arnebrasseur/openerp-account_invoice_total by arne brasseur and simplified by myself.

Revision history for this message

Joël Grand-Guillaume @ camptocamp (jgrandguillaume-c2c) wrote on 2012-11-20:

Ok for me. Code looks ok, good place to be committed IMHO.

review: Approve

lp://staging/~sbi/account-invoicing/6.1-account_invoice_total updated on 2012-11-21

13. By Stéphane Bidoul (Acsone) on 2012-11-21: [IMP] account_invoice_total has 2 authors

Revision history for this message

Stéphane Bidoul (Acsone) (sbi) wrote on 2012-12-03:

What's the next step for merging this one?

Revision history for this message

Stefan Rijnhart (Opener) (stefan-opener) wrote on 2012-12-03:

Hi,

merged with an additional comment about this option in 7.0

Cheers,
Stefan.

Revision history for this message

Niels Huylebroeck (red15) wrote on 2012-12-03:

What is the purpose of the README.md file ? Is this some form of markup ? If so we should as community gather around a central format which everyone can agree upon so we can make such files a requirement when committing new modules.

Also a bit strange why required="2" on the check_total field ? Why is value 2 not 1 or True, I prefer the latter personally.

Revision history for this message

Stéphane Bidoul (Acsone) (sbi) wrote on 2012-12-03:

md is for markdown. That said, README.md is redundant to __openerp__.py and could be removed.

The required="2" comes from the 6.0 account_invoice_view.xml. I have no idea if it means something different than 1 or True.

-sbi