Merge ~sbeattie/qa-regression-testing:ecdsautils-lp-ci into qa-regression-testing:master

Proposed by Steve Beattie
Status: Needs review
Proposed branch: ~sbeattie/qa-regression-testing:ecdsautils-lp-ci
Merge into: qa-regression-testing:master
Diff against target: 227 lines (+95/-41)
2 files modified
.launchpad.yaml (+16/-0)
scripts/test-ecdsautils.py (+79/-41)
Reviewer Review Type Date Requested Status
Ubuntu Security Team Pending
Review via email: mp+448427@code.staging.launchpad.net

Commit message

test-ecdsautils: misc improvements and enable in LP CI

Steve Beattie (5):
      * [062bea06] test-ecdsautils.py: convert ecdsaTest to use subTests for each test vector
      * [32aea5d4] test-ecdsautils.py: multiple improvements
      * [e1613441] test-ecdsautils.py: add a couple more signature boundary condition tests
      * [1e837ae0] .launchpad.yaml: enable ecdsautils test in LP CI
      * [35b4abe2] .launchpad.yaml: disable test-ecdsautils in LP CI for bionic

Description of the change

test-ecdsautils: misc improvements and enable in LP CI

Adjust tests to make use of the subtests infrastructure, as well as use more the testlib command infrastructure to ensure that error codes are caught and trigger test failures. Also add a couple more of boundary condition checks similar to the test for CVE-2022-24884.

Finally, and the primary point I'd like to have a review / discussion on, is to enable running the tests in LP CI, but disabled for bionic becuase the CVE-2022-24884 is only available in the Ubuntu Pro archive, and so the tests are guaranteed to fail there. I'm not convinced this is the right approach to handle this. As bionic's time in ESM status grows, this is only going to be more of a problem, so we should come up with a coherent process for this, as well as for things where fixes only live in the Pro Apps archive.

To post a comment you must log in.

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches