Autopilot

Merge lp://staging/~sbaldassin/autopilot/fix_mir into lp://staging/autopilot

  1. fix_mir
  2. Merge into trunk
Proposed by Santiago Baldassin
Status: Merged
Approved by: Heber Parrucci
Approved revision: 589
Merged at revision: 589
Proposed branch: lp://staging/~sbaldassin/autopilot/fix_mir
Merge into: lp://staging/autopilot
Diff against target: 41 lines (+17/-7)
1 file modified
autopilot/display/_upa.py (+17/-7)
To merge this branch: bzr merge lp://staging/~sbaldassin/autopilot/fix_mir
Reviewer Review Type Date Requested Status
Heber Parrucci (community) Approve
platform-qa-bot continuous-integration Approve
Omer Akram (community) Needs Fixing
Review via email: mp+313729@code.staging.launchpad.net

Commit message

Adding default resolutions to create the upa display

Description of the change

Adding the default resolutions back so that people can still run tests through shh using autopilot

To post a comment you must log in.
Revision history for this message
platform-qa-bot (platform-qa-bot) wrote :

FAILED: Continuous integration, rev:586
https://platform-qa-jenkins.ubuntu.com/job/autopilot-ci/111/
Executed test runs:
    FAILURE: https://platform-qa-jenkins.ubuntu.com/job/build-xenial-amd64-package/213/console
    FAILURE: https://platform-qa-jenkins.ubuntu.com/job/build-xenial-i386-package/211/console
    None: https://platform-qa-jenkins.ubuntu.com/job/generic-update-mp/1481/console

Click here to trigger a rebuild:
https://platform-qa-jenkins.ubuntu.com/job/autopilot-ci/111/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Omer Akram (om26er) wrote :

Please check my inline comment on how this approach is flawed.

review: Needs Fixing
Revision history for this message
Santiago Baldassin (sbaldassin) wrote :

Reply inline

lp://staging/~sbaldassin/autopilot/fix_mir updated
587. By Santiago Baldassin

Adding default resolutions for M10 and desktop and removing non supported devices

588. By Santiago Baldassin

fixing flake8 errors

Revision history for this message
platform-qa-bot (platform-qa-bot) wrote :

PASSED: Continuous integration, rev:588
https://platform-qa-jenkins.ubuntu.com/job/autopilot-ci/112/
Executed test runs:
    SUCCESS: https://platform-qa-jenkins.ubuntu.com/job/build-xenial-amd64-package/224
        deb: https://platform-qa-jenkins.ubuntu.com/job/build-xenial-amd64-package/224/artifact/work/output/*zip*/output.zip
    SUCCESS: https://platform-qa-jenkins.ubuntu.com/job/build-xenial-i386-package/222
        deb: https://platform-qa-jenkins.ubuntu.com/job/build-xenial-i386-package/222/artifact/work/output/*zip*/output.zip
    None: https://platform-qa-jenkins.ubuntu.com/job/generic-update-mp/1502/console

Click here to trigger a rebuild:
https://platform-qa-jenkins.ubuntu.com/job/autopilot-ci/112/rebuild

review: Approve (continuous-integration)
Revision history for this message
Heber Parrucci (heber013) wrote :

see comment

review: Needs Fixing
Revision history for this message
Santiago Baldassin (sbaldassin) wrote :

Comment addressed

lp://staging/~sbaldassin/autopilot/fix_mir updated
589. By Santiago Baldassin

minor fix

Revision history for this message
Heber Parrucci (heber013) wrote :

Code LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches