OpenERP - Human Resources

Merge lp://staging/~savoirfairelinux-openerp/openerp-hr/resume into lp://staging/openerp-hr/6.1

  1. resume
  2. Merge into 6.1
Status: Merged
Merged at revision: 307
Proposed branch: lp://staging/~savoirfairelinux-openerp/openerp-hr/resume
Merge into: lp://staging/openerp-hr/6.1
Diff against target: 524 lines (+472/-0)
10 files modified
hr_resume/__init__.py (+25/-0)
hr_resume/__openerp__.py (+55/-0)
hr_resume/hr_resume.py (+31/-0)
hr_resume/hr_resume_view.xml (+18/-0)
hr_resume/i18n/fr.po (+79/-0)
hr_resume/i18n/hr_resume.pot (+79/-0)
hr_resume/report/__init__.py (+24/-0)
hr_resume/report/report_resume.py (+49/-0)
hr_resume/report/report_resume.rml (+99/-0)
hr_resume/report/report_resume.xml (+13/-0)
To merge this branch: bzr merge lp://staging/~savoirfairelinux-openerp/openerp-hr/resume
Reviewer Review Type Date Requested Status
Joël Grand-Guillaume @ camptocamp code review, no tests Approve
Omar (Pexego) code review Approve
Maxime Chambreuil (http://www.savoirfairelinux.com) code review Approve
Review via email: mp+194927@code.staging.launchpad.net

Description of the change

[ADD] add hr_resume module.It inherits the emloyee view form and adds a report printing resume

To post a comment you must log in.
Revision history for this message
Maxime Chambreuil (http://www.savoirfairelinux.com) (max3903) wrote :

Diff is empty.

review: Needs Fixing
lp://staging/~savoirfairelinux-openerp/openerp-hr/resume updated
307. By EL HADJI DEM <email address hidden>

[ADD] adds hr_resume module

308. By EL HADJI DEM <email address hidden>

[IMP] add pot file

Revision history for this message
Maxime Chambreuil (http://www.savoirfairelinux.com) (max3903) :
review: Approve (code review)
Revision history for this message
Omar (Pexego) (omar7r) wrote :

LGTM

review: Approve (code review)
lp://staging/~savoirfairelinux-openerp/openerp-hr/resume updated
309. By El Hadji Dem (http://www.savoirfairelinux.com)

[IMP] change report, pep8

Revision history for this message
Joël Grand-Guillaume @ camptocamp (jgrandguillaume-c2c) wrote :

Hi,

Thanks for the contrib. Would have been great to use "from . import XY" at line 27 and 28. But otherwise good. Don't want to block that little one for that.

Thanks

review: Approve (code review, no tests)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches