OpenERP - Human Resources

Merge lp://staging/~savoirfairelinux-openerp/openerp-hr/7.0-skill into lp://staging/openerp-hr

  1. 7.0-skill
  2. Merge into 7.0
Status: Merged
Merged at revision: 68
Proposed branch: lp://staging/~savoirfairelinux-openerp/openerp-hr/7.0-skill
Merge into: lp://staging/openerp-hr
Diff against target: 339 lines (+306/-0)
6 files modified
hr_skill/__init__.py (+22/-0)
hr_skill/__openerp__.py (+42/-0)
hr_skill/hr_skill.py (+48/-0)
hr_skill/hr_skill_view.xml (+99/-0)
hr_skill/i18n/hr_skill.pot (+92/-0)
hr_skill/security/ir.model.access.csv (+3/-0)
To merge this branch: bzr merge lp://staging/~savoirfairelinux-openerp/openerp-hr/7.0-skill
Reviewer Review Type Date Requested Status
Maxime Chambreuil (http://www.savoirfairelinux.com) code review Approve
Daniel Reis Approve
Review via email: mp+195302@code.staging.launchpad.net

Description of the change

[ADD] adds hr_skill module

To post a comment you must log in.
Revision history for this message
Maxime Chambreuil (http://www.savoirfairelinux.com) (max3903) wrote :

El Hadji,

l81: Please fix the copyright.

l144, 122: You don't need to instantiate a class in 7.0.

Translation needs to be updated to reflect the new fields and views.

review: Needs Fixing (code review)
Revision history for this message
El Hadji Dem (http://www.savoirfairelinux.com) (eh-dem) wrote :

> El Hadji,
>
> l81: Please fix the copyright.
>
> l144, 122: You don't need to instantiate a class in 7.0.
>
> Translation needs to be updated to reflect the new fields and views.

Ok maxime

lp://staging/~savoirfairelinux-openerp/openerp-hr/7.0-skill updated
69. By EL HADJI DEM <email address hidden>

[IMP] fix the copyright and update to reflect the new fields and views

70. By EL HADJI DEM <email address hidden>

[IMP] don't need to instantiate a class in 7.0

71. By EL HADJI DEM <email address hidden>

[IMP] add pot file

Revision history for this message
Daniel Reis (dreis-pt) wrote :

Looks good to me.

One remark: the domain for the employee skill_ids is defined on the form; wouldn't be better to have it on the model instead?

review: Approve
lp://staging/~savoirfairelinux-openerp/openerp-hr/7.0-skill updated
72. By EL HADJI DEM <email address hidden>

[IMP] the domain for the employee skill ids is defined on the model instead on the form

Revision history for this message
Maxime Chambreuil (http://www.savoirfairelinux.com) (max3903) :
review: Approve (code review)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.