Merge lp://staging/~savoirfairelinux-openerp/openerp-hr/6.1-fix-hr-skill-demo-data into lp://staging/openerp-hr/6.1

Status: Merged
Merged at revision: 314
Proposed branch: lp://staging/~savoirfairelinux-openerp/openerp-hr/6.1-fix-hr-skill-demo-data
Merge into: lp://staging/openerp-hr/6.1
Diff against target: 3434 lines (+291/-2837)
38 files modified
hr_experience_analytic/__init__.py (+22/-0)
hr_experience_analytic/__openerp__.py (+44/-0)
hr_experience_analytic/hr_experience_analytic.py (+30/-0)
hr_experience_analytic/hr_experience_analytic_view.xml (+17/-0)
hr_skill/__init__.py (+7/-9)
hr_skill/__openerp__.py (+16/-17)
hr_skill/hr_skill.evaluation.category.csv (+0/-2)
hr_skill/hr_skill.evaluation.csv (+0/-2)
hr_skill/hr_skill.experience.category.csv (+0/-5)
hr_skill/hr_skill.experience.csv (+0/-1)
hr_skill/hr_skill.position.csv (+0/-3)
hr_skill/hr_skill.profile.csv (+0/-5)
hr_skill/hr_skill.py (+26/-241)
hr_skill/hr_skill.skill.csv (+0/-12)
hr_skill/hr_skill.weight.category.csv (+0/-3)
hr_skill/hr_skill.weight.csv (+0/-8)
hr_skill/hr_skill_demo.xml (+0/-19)
hr_skill/hr_skill_report.xml (+0/-15)
hr_skill/hr_skill_view.xml (+67/-305)
hr_skill/hrskill.py (+0/-92)
hr_skill/hrskill_view.xml (+0/-220)
hr_skill/i18n/hr_skill.pot (+60/-556)
hr_skill/lang_wiz_view.xml (+0/-31)
hr_skill/old-hr_skill.skill.csv (+0/-12)
hr_skill/old-hr_skill_view.xml (+0/-148)
hr_skill/report/__init__.py (+0/-25)
hr_skill/report/datereport.rml (+0/-142)
hr_skill/report/employeereport.py (+0/-57)
hr_skill/report/evaluation.rml (+0/-192)
hr_skill/report/langreport.py (+0/-112)
hr_skill/report/langreport.rml (+0/-175)
hr_skill/report/skillreport.py (+0/-61)
hr_skill/report/skillreport.rml (+0/-161)
hr_skill/security/ir.model.access.csv (+2/-18)
hr_skill/wizard/__init__.py (+0/-25)
hr_skill/wizard/datewise.py (+0/-54)
hr_skill/wizard/lang_wiz.py (+0/-60)
hr_skill/wizard/skill.py (+0/-49)
To merge this branch: bzr merge lp://staging/~savoirfairelinux-openerp/openerp-hr/6.1-fix-hr-skill-demo-data
Reviewer Review Type Date Requested Status
Joël Grand-Guillaume @ camptocamp code review, no tests Approve
Maxime Chambreuil (http://www.savoirfairelinux.com) code review and test Approve
Pedro Manuel Baeza Pending
Review via email: mp+194763@code.staging.launchpad.net

Description of the change

[FIX] PEP8 issue
[IMP] Cleanup hr_skill
[IMP] Demo data installable.
[ADD] hr_experience_analytic

To post a comment you must log in.
Revision history for this message
Pedro Manuel Baeza (pedro.baeza) wrote :

Hi, El Hadji, thank you very much for these two useful modules, but can you please add each of them on separate MPs to make easier the reviewing process?

Let me know if you need help on something.

Regards.

325. By Maxime Chambreuil (http://www.savoirfairelinux.com)

[DEL] Modules moved to other branches to separate MPs

Revision history for this message
Maxime Chambreuil (http://www.savoirfairelinux.com) (max3903) wrote :

Hello Pedro,

We have moved modules to other branches.

There is only hr_experience_analytic left here with some cleanup of hr_skill.

Revision history for this message
Maxime Chambreuil (http://www.savoirfairelinux.com) (max3903) :
review: Approve (code review and test)
326. By Maxime Chambreuil (http://www.savoirfairelinux.com)

[IMP] Menu

327. By Maxime Chambreuil (http://www.savoirfairelinux.com)

[IMP] Update translation file

328. By Maxime Chambreuil (http://www.savoirfairelinux.com)

[IMP] Replace hr.experience by hr.professional

329. By Maxime Chambreuil (http://www.savoirfairelinux.com)

[IMP] Fix view

Revision history for this message
Joël Grand-Guillaume @ camptocamp (jgrandguillaume-c2c) wrote :

Hi,

Thanks for the contribs ! It would have been godd to replace osv.osv by orm.Model, but otherwise looks good to me.

Regards,

Joël

review: Approve (code review, no tests)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches