Unity 8

Merge lp://staging/~saviq/unity8/fix-parallel-build into lp://staging/unity8

  1. fix-parallel-build
  2. Merge into trunk
Proposed by Michał Sawicz
Status: Merged
Approved by: Michał Sawicz
Approved revision: 1637
Merged at revision: 1675
Proposed branch: lp://staging/~saviq/unity8/fix-parallel-build
Merge into: lp://staging/unity8
Diff against target: 238 lines (+103/-32)
6 files modified
plugins/LightDM/liblightdm/GreeterPrivate.cpp (+14/-5)
plugins/LightDM/liblightdm/GreeterPrivate.h (+1/-1)
tests/mocks/LightDM/CMakeLists.txt (+2/-5)
tests/mocks/Unity/Indicators/CMakeLists.txt (+1/-3)
tests/plugins/LightDM/CMakeLists.txt (+33/-18)
tests/plugins/LightDM/pam.cpp (+52/-0)
To merge this branch: bzr merge lp://staging/~saviq/unity8/fix-parallel-build
Reviewer Review Type Date Requested Status
Albert Astals Cid (community) Approve
PS Jenkins bot (community) continuous-integration Needs Fixing
Review via email: mp+251455@code.staging.launchpad.net

Commit message

Use targets instead of custom ld arguments for linking

This allows for implied dependencies

Description of the change

 * Are there any related MPs required for this MP to build/function as expected? Please list.
N/A
 * Did you perform an exploratory manual test run of your code change and any related functionality?
Y
 * Did you make sure that your branch does not contain spurious tags?
Y
 * If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
N/A
 * If you changed the UI, has there been a design review?
N/A

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:1637
http://jenkins.qa.ubuntu.com/job/unity8-ci/5375/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/1602
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-vivid/539
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-vivid-amd64-ci/540
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-vivid-i386-ci/540
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/1421
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/1600
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/1600/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/18471

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/5375/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Albert Astals Cid (aacid) wrote :

 * Did you perform an exploratory manual test run of the code change and any related functionality?
It's a build chain fix only

 * Did CI run pass?
Yes

 * Did you make sure that the branch does not contain spurious tags?
Yes

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches