Merge lp://staging/~saviq/unity8/fix-edges-demo into lp://staging/unity8

Proposed by Michał Sawicz
Status: Rejected
Rejected by: Michael Terry
Proposed branch: lp://staging/~saviq/unity8/fix-edges-demo
Merge into: lp://staging/unity8
Diff against target: 127 lines (+13/-35)
2 files modified
qml/Components/EdgeDemo.qml (+12/-15)
qml/Shell.qml (+1/-20)
To merge this branch: bzr merge lp://staging/~saviq/unity8/fix-edges-demo
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Michael Terry Needs Fixing
Review via email: mp+229778@code.staging.launchpad.net

Commit message

Fix edges demo, drop underlay as it was never visible any more.

Description of the change

 * Are there any related MPs required for this MP to build/function as expected? Please list.
No.

 * Did you perform an exploratory manual test run of your code change and any related functionality?
Yes.

 * Did you make sure that your branch does not contain spurious tags?
Yes.

 * If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
N/A

 * If you changed the UI, has there been a design review?
N/A

To post a comment you must log in.
Revision history for this message
Michael Terry (mterry) wrote :

Comments inline.

review: Needs Fixing
Revision history for this message
Michał Sawicz (saviq) :
Revision history for this message
Michael Terry (mterry) wrote :

Marking this rejected, in favor of lp:~mterry/unity8/dash-app-demo-fixes

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)

Unmerged revisions

1115. By Michał Sawicz

Fix demo edges, remove underlay which was never visible any more.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches