Code review comment for lp://staging/~saviq/unity-2d/unmaximize-on-drag

Revision history for this message
MichaƂ Sawicz (saviq) wrote :

> Is there any particular reason why you used invokeMethod instead of using
> qobject_cast<MenuBarWidget*>(m_widget) and they if the cast succeeded just
> call the method directly ?

I was just following what the rest of the code did. Seemed like a good way to encapsulate things, but since it's supposed to go into MenuBarWidget I might as well call it directly.

« Back to merge proposal