Merge lp://staging/~saviq/qtubuntu/revert-application.active into lp://staging/qtubuntu

Proposed by Michał Sawicz
Status: Work in progress
Proposed branch: lp://staging/~saviq/qtubuntu/revert-application.active
Merge into: lp://staging/qtubuntu
Diff against target: 70 lines (+5/-16)
3 files modified
src/ubuntumirclient/input.cpp (+0/-7)
src/ubuntumirclient/integration.cpp (+4/-9)
src/ubuntumirclient/window.cpp (+1/-0)
To merge this branch: bzr merge lp://staging/~saviq/qtubuntu/revert-application.active
Reviewer Review Type Date Requested Status
Daniel d'Andrada (community) Disapprove
PS Jenkins bot continuous-integration Approve
Review via email: mp+281253@code.staging.launchpad.net

Commit message

Revert r298 that broke Qt.application.state

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Daniel d'Andrada (dandrader) wrote :

I think the fix should be as simple as not deleting the code that the original MP removed, instead of reverting everything.

Revision history for this message
Daniel d'Andrada (dandrader) wrote :

> I think the fix should be as simple as not deleting the code that the original
> MP removed, instead of reverting everything.

Hmmm, actually the problem is not that as we don't have to send the deprecated events since Qt feeds the deprecated API from the new one.

It's about a behavioral change really, as that new code is more accurate but it maybe hit some bug, like after unlock the foreground app doesn't have focus or something. investigating.

Revision history for this message
Daniel d'Andrada (dandrader) wrote :
review: Disapprove

Unmerged revisions

302. By Michał Sawicz

Revert r298 that broke Qt.application.state

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches