The Savilerow project

Merge lp://staging/~savilerow-team/savilerow/unity-scope-tourism--fix-libdir-path into lp://staging/~savilerow-team/savilerow/unity-scope-tourism

  1. unity-scope-tourism--fix-libdir-path
  2. Merge into unity-scope-tourism
Proposed by Michał Karnicki
Status: Merged
Merged at revision: 10
Proposed branch: lp://staging/~savilerow-team/savilerow/unity-scope-tourism--fix-libdir-path
Merge into: lp://staging/~savilerow-team/savilerow/unity-scope-tourism
Diff against target: 15 lines (+2/-2)
1 file modified
CMakeLists.txt (+2/-2)
To merge this branch: bzr merge lp://staging/~savilerow-team/savilerow/unity-scope-tourism--fix-libdir-path
Reviewer Review Type Date Requested Status
Chris Wayne (community) Approve
Review via email: mp+222001@code.staging.launchpad.net

Description of the change

Update libdir path.

To post a comment you must log in.
Revision history for this message
Chris Wayne (cwayne) wrote :

Is there a way to abstract out the arm-linx-gnueahibhf based on the arch of the builder? It'd be nice to be able to have these scopes built/working on x86 emulators as well

Revision history for this message
XiaoGuo, Liu (liu-xiao-guo) wrote :

I strong agree with that. it is even much easier to debug a program on the
x86 desktop as well. Currently,

http://developer.ubuntu.com/scopes/tutorials/unity-8-scope-example-openclipart/

can be successfully running on the desktop environment. Is there any way to
make the file path relative to the running environment instead of being an
absolute path in the json files?

Thanks & best regards,
XiaoGuo

On Wed, Jun 4, 2014 at 8:33 PM, Chris Wayne <email address hidden>
wrote:

> Is there a way to abstract out the arm-linx-gnueahibhf based on the arch
> of the builder? It'd be nice to be able to have these scopes built/working
> on x86 emulators as well
> --
>
> https://code.launchpad.net/~savilerow-team/savilerow/unity-scope-tourism--fix-libdir-path/+merge/222001
> Your team The Savilerow team is requested to review the proposed merge of
> lp:~savilerow-team/savilerow/unity-scope-tourism--fix-libdir-path into
> lp:~savilerow-team/savilerow/unity-scope-tourism.
>

--
XiaoGuo, Liu (刘晓国）
Mobile: +86-13911181302
Skype ID: liu_xiao_guo
IRC: liuxg

Revision history for this message
Michał Karnicki (karni) wrote :

We're have a task noted to look into it, XiaoGuo.

Revision history for this message
Chris Wayne (cwayne) wrote :

Line 11: SET(SCOPE_INSTALL_DIR ${CUSTOM_INSTALL_LIBDIR}/unity/scopes/scope-tourism/)

should be SET(SCOPE_INSTALL_DIR ${CUSTOM_INSTALL_LIBDIR/unity-scopes/scope-tourism

review: Needs Fixing
lp://staging/~savilerow-team/savilerow/unity-scope-tourism--fix-libdir-path updated
11. By Michał Karnicki

Fix libdir install path.

Revision history for this message
Chris Wayne (cwayne) wrote :

How was this tested?

Revision history for this message
Michał Karnicki (karni) wrote :

Tested: Build, installed and ran on the phone.

Revision history for this message
Chris Wayne (cwayne) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: