The Savilerow project

Merge lp://staging/~savilerow-team/savilerow/unity-scope-selfserviceplan-newapi into lp://staging/~savilerow-team/savilerow/unity-scope-selfserviceplan

  1. unity-scope-selfserviceplan-newapi
  2. Merge into unity-scope-selfserviceplan
Proposed by Chris Wayne
Status: Merged
Merged at revision: 15
Proposed branch: lp://staging/~savilerow-team/savilerow/unity-scope-selfserviceplan-newapi
Merge into: lp://staging/~savilerow-team/savilerow/unity-scope-selfserviceplan
Diff against target: 150 lines (+25/-19)
6 files modified
CMakeLists.txt (+2/-2)
debian/changelog (+6/-0)
src/SelfServicePlanQuery.cpp (+2/-2)
src/SelfServicePlanQuery.h (+4/-4)
src/SelfServicePlanScope.cpp (+7/-7)
src/SelfServicePlanScope.h (+4/-4)
To merge this branch: bzr merge lp://staging/~savilerow-team/savilerow/unity-scope-selfserviceplan-newapi
Reviewer Review Type Date Requested Status
Scott Sweeny (community) Approve
Review via email: mp+212890@code.staging.launchpad.net

Description of the change

New api

To post a comment you must log in.
Revision history for this message
Scott Sweeny (ssweeny) wrote :

75 - header.add_component("title", "title");
76 + header.add_atribute_mapping("title", "title");
77
78 PreviewWidget art("art", "image");
79 - art.add_component("source", "art");
80 + art.add_atribute_mapping("source", "art");
81
82 PreviewWidget description("description", "text");
83 - description.add_component("text", "summary");
84 + description.add_atribute_mapping("text", "summary");

Should be add_attribute_mapping

review: Needs Fixing
lp://staging/~savilerow-team/savilerow/unity-scope-selfserviceplan-newapi updated
16. By Chris Wayne

Typing is hard

Revision history for this message
Scott Sweeny (ssweeny) wrote :

Retested and B/I/R for me. Looks good.

review: Approve
lp://staging/~savilerow-team/savilerow/unity-scope-selfserviceplan-newapi updated
17. By Chris Wayne

releasing package unity-scope-selfserviceplan version 0.3

18. By Chris Wayne

Fix install location

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: