Code review comment for ~santoshbit2007/oxide:GetShellMode_Implementation

Revision history for this message
Santosh (santoshbit2007) wrote :

Just to note, QtSystemInfo is not yet in ubuntu image, but silo to include it in image is in testing phase, so we might get it with ubuntu Image.

For images, QtsystemInfo is not available, user need install package libqt5systeminfo5

May be we should use declare some #define to check availability for package and write code within that check. Any suggestion is welcomed.
 e.g all the code below should put within
#if defined QT5_SYSTEM_INFO
  // code
#endif

« Back to merge proposal