Merge ~santoshbit2007/oxide:GetShellMode_Implementation into oxide:master
Proposed by
Santosh
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Merge reported by: | Santosh | ||||
| Merged at revision: | not available | ||||
| Proposed branch: | ~santoshbit2007/oxide:GetShellMode_Implementation | ||||
| Merge into: | oxide:master | ||||
| Diff against target: |
404 lines (+176/-9) 13 files modified
build/cmake/ChromiumBuildShim.cmake (+13/-0) build/config/Qt5/BUILD.gn (+8/-0) build/config/Qt5/moc.gni (+12/-3) build/config/Qt5/moc.py (+6/-1) build/config/build_flags.gni (+2/-0) build/config/linux/qt/BUILD.gn (+7/-0) qt/core/BUILD.gn (+14/-0) qt/core/browser/qt_screen.cc (+90/-0) qt/core/browser/qt_screen.h (+18/-0) shared/browser/oxide_content_browser_client.cc (+1/-1) shared/browser/screen.h (+1/-1) shared/browser/screen_observer.h (+1/-0) shared/browser/screen_unittest.cc (+3/-3) |
||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Chris Coulson | Approve | ||
|
Review via email:
|
|||
Description of the change
Implement shell mode change detection based on
scanning of input devices.
To post a comment you must log in.
Revision history for this message
| Santosh (santoshbit2007) wrote | # |
Revision history for this message
| Santosh (santoshbit2007) | # |
Revision history for this message
| Chris Coulson (chrisccoulson) | # |
Revision history for this message
| Santosh (santoshbit2007) | # |
Revision history for this message
| Chris Coulson (chrisccoulson) | # |
review:
Approve
There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Just to note, QtSystemInfo is not yet in ubuntu image, but silo to include it in image is in testing phase, so we might get it with ubuntu Image.
For images, QtsystemInfo is not available, user need install package libqt5systeminfo5
May be we should use declare some #define to check availability for package and write code within that check. Any suggestion is welcomed.
e.g all the code below should put within
#if defined QT5_SYSTEM_INFO
// code
#endif