Merge lp://staging/~samuel-buffet/entertainer/ftx1 into lp://staging/entertainer
Proposed by
Samuel Buffet
Status: | Merged | ||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Merged at revision: | not available | ||||||||||||||||||||
Proposed branch: | lp://staging/~samuel-buffet/entertainer/ftx1 | ||||||||||||||||||||
Merge into: | lp://staging/entertainer | ||||||||||||||||||||
To merge this branch: | bzr merge lp://staging/~samuel-buffet/entertainer/ftx1 | ||||||||||||||||||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Paul Hummer | Approve | ||
Review via email: mp+2651@code.staging.launchpad.net |
To post a comment you must log in.
There's no need to handle anything on timelines on those callbacks. The timeline can be usefull to get the frame number, the total number of frames etc... when the timeline is *playing* but those callbacks are called when the timeline is *completed*
the diff : /frontend/ gui/screens/ photoalbums_ screen. py' frontend/ gui/screens/ photoalbums_ screen. py 2008-12-14 22:46:36 +0000 frontend/ gui/screens/ photoalbums_ screen. py 2009-01-06 11:01:42 +0000 preview_ timeline_ ended(self, timeline, group):
self. remove( group)
=== modified file 'entertainerlib
--- entertainerlib/
+++ entertainerlib/
@@ -236,10 +236,9 @@
def _change_
"""
This is a callback function for preview updates. This is called when
- transition effect is finished. This mehtod removes old preview group
+ transition effect is finished. This method removes old preview group
from the stage.
"""
- # TODO: Figure out if/how timeline needs to be used
def _change_ preview_ image(self) :
=== modified file 'entertainerlib /frontend/ gui/transitions /fade_transitio n.py' frontend/ gui/transitions /fade_transitio n.py 2008-10-07 22:59:41 +0000 frontend/ gui/transitions /fade_transitio n.py 2009-01-06 11:01:42 +0000
self. forward_ effect( from_screen, to_screen)
--- entertainerlib/
+++ entertainerlib/
@@ -70,11 +70,3 @@
# Same effect. Direction doesn't make any difference
- def _remove_ from_stage_ callback( self, timeline, screen): remove( screen)
- """
- Callback for fadeout timeline. This method is called when transition
- direction is BACKWARDS. This method removes old screen from stage.
- """
- # TODO: Determine if timeline needs to be used somehow
- self.stage.
-
=== modified file 'entertainerlib /frontend/ gui/transitions /slide_ and_fade_ transition. py' frontend/ gui/transitions /slide_ and_fade_ transition. py 2008-10-07 22:59:41 +0000 frontend/ gui/transitions /slide_ and_fade_ transition. py 2009-01-06 11:01:42 +0000
slide_ out.start( )
slide_ in.start( )
--- entertainerlib/
+++ entertainerlib/
@@ -162,11 +162,3 @@
- def _remove_ from_stage_ callback( self, timeline, screen): remove( screen)
- """
- Callback for fadeout timeline. This method is called when transition
- direction is BACKWARDS. This method removes old screen from stage.
- """
- # TODO: Figure out if timeline needs to be used somehow
- self.stage.
-
=== modified file 'entertainerlib /frontend/ gui/transitions /slide_ transition. py' frontend/ gui/transitions /slide_ transition. py 2008-10-07 22:59:41 +0000 frontend/ gui/transitions /slide_ transition. py 2009-01-06 11:01:42 +0000
slide_ out.start( )
slide_ in.start( )
--- entertainerlib/
+++ entertainerlib/
@@ -153,11 +153,3 @@
- def _remove_ from_stage_ callback( self, timeline, screen): remove( screen)
- """
- Callback for fadeout timeline. This method is called when transition
- direction is BACKWARDS. This method removes old screen from stage.
- """
- # TODO: Determine if timeline should be used.
- self.stage.
-
=== modified file 'entertainerlib /frontend/ gui/transitions /transitio. ..